Bug report - can't star a track

Alternative Android Client for Subsonic

Moderators: daneren2005, moderators

Bug report - can't star a track

Postby flvinny521 » Tue Mar 12, 2013 12:59 pm

Starring any track, whether cached or currently downloading from the server, returns a "ServerTooOldException" error message and it does not get scrobbled to last.fm as a starred track.

I would also love the ability to star a track from the widget and/or notification controls.
flvinny521
 
Posts: 70
Joined: Thu Jul 28, 2011 1:48 pm

Re: Bug report - can't star a track

Postby bushman4 » Tue Mar 12, 2013 2:22 pm

What server version are you running? It sounds like you are running an older version of Subsonic, or Music Cabinet (which uses an old version of the REST API that does not support star-ing tracks).

GLenn
Glenn Sullivan
Subsonic 6.1.6 (Unraid Docker)
90 regular Subsonic Users

Library as of 2024-10-28:
4,527 artists
19,996 albums
282,151 songs
10201.40 GB
41,583 hours
User avatar
bushman4
 
Posts: 874
Joined: Thu Dec 02, 2010 1:47 pm
Location: Massachusetts, USA

Re: Bug report - can't star a track

Postby flvinny521 » Tue Mar 12, 2013 2:29 pm

I am using MusicCabinet 0.7.22.

I am able to star tracks from within the MusicCabinet web UI.

Edit:

Code: Select all
Subsonic, originally written by Sindre Mehus. Built with MusicCabinet plugin, version 0.7.22, on February 13, 2013.

Code: Select all
jetty/8.y.z-SNAPSHOT, java 1.7.0_17, Windows 7 (92.5 MB / 145.0 MB)
Last edited by flvinny521 on Tue Mar 12, 2013 2:30 pm, edited 1 time in total.
flvinny521
 
Posts: 70
Joined: Thu Jul 28, 2011 1:48 pm

Re: Bug report - can't star a track

Postby mr_nobody » Tue Mar 12, 2013 2:29 pm

This is a music cabinet issue.

[edit]: See here:

viewtopic.php?f=16&t=11268&p=51843&hilit=ServerTooOldException#p51843
mr_nobody
 
Posts: 202
Joined: Thu May 31, 2012 8:17 pm

Re: Bug report - can't star a track

Postby bushman4 » Tue Mar 12, 2013 2:34 pm

flvinny521 wrote:I am able to star tracks from within the MusicCabinet web UI.


The WebUI does not use the REST API, which is the remote application programming interface. The REST API of Music Cabinet is not running at subsonic version 4.7 like the rest of the app is.

Glenn
Glenn Sullivan
Subsonic 6.1.6 (Unraid Docker)
90 regular Subsonic Users

Library as of 2024-10-28:
4,527 artists
19,996 albums
282,151 songs
10201.40 GB
41,583 hours
User avatar
bushman4
 
Posts: 874
Joined: Thu Dec 02, 2010 1:47 pm
Location: Massachusetts, USA

Re: Bug report - can't star a track

Postby flvinny521 » Tue Mar 12, 2013 2:38 pm

Thank you for the push in the right direction!
flvinny521
 
Posts: 70
Joined: Thu Jul 28, 2011 1:48 pm

Re: Bug report - can't star a track

Postby hakko » Tue Mar 12, 2013 9:14 pm

Starring via REST API is actually supported in MusicCabinet (and would automatically "love" the track on last.fm), even though the server reports itself as version 4.6. I wish it was possible to report versions a bit more fine-grained. Maybe I have to start reporting it as version 4.7 and throw exceptions on the methods that aren't implemented.
MusicCabinet developer
hakko
 
Posts: 1416
Joined: Tue Apr 17, 2012 7:05 pm
Location: Sweden

Re: Bug report - can't star a track

Postby hakko » Tue Mar 12, 2013 9:20 pm

I also somehow need to be more clear about what MusicCabinet is and what it's not. Originally, I started working with the Subsonic 4.6 code base which was the latest stable release at that point in time. Then I threw out the whole media handling because it was super inefficiently written and wrote my own library to handle it. Then I incorporated some changes that I liked from Subsonic 4.7 (or actually only the new starring system, I think. but only the icons, I had to write the code myself again). I'd guess that around 50% of the code from Subsonic 4.6 is left and the rest is written by me. I'm striving to get that percentage even further down.

I do strive to be compatible with the 4.7 release though, so sooner or later I'll add the missing methods and start reporting myself as 4.7 even though the code base behind it is completely different.
MusicCabinet developer
hakko
 
Posts: 1416
Joined: Tue Apr 17, 2012 7:05 pm
Location: Sweden

Re: Bug report - can't star a track

Postby daneren2005 » Tue Mar 12, 2013 9:37 pm

Yah there just isn't really a good way for the client to tell what is going to be available on the server without using the version. Honestly, I think the tipping point will be adding support for the update playlist command. That seems to be 99% of what I get asked by, so after you added that you could relatively safely start reporting as a 4.7 server.
Developer of DSub for Android
daneren2005
 
Posts: 1709
Joined: Fri Jul 06, 2012 7:52 pm

Re: Bug report - can't star a track

Postby hakko » Tue Mar 12, 2013 9:50 pm

We're getting off-topic here but in this method:

http://www.subsonic.org/pages/api.jsp#updatePlaylist

do you assume that playlistId is an integer, or could it be the full path of a playlist?
MusicCabinet developer
hakko
 
Posts: 1416
Joined: Tue Apr 17, 2012 7:05 pm
Location: Sweden

Re: Bug report - can't star a track

Postby daneren2005 » Tue Mar 12, 2013 9:58 pm

The playlist ID is literally whatever string is passed into http://subsonic.svn.sourceforge.net/vie ... iew=markup. My app treats it as a String, though I'm not sure if others such as iSub do as well. So in my case you can make the id whatever the hell you want, as long as the id's match up in both places.
Developer of DSub for Android
daneren2005
 
Posts: 1709
Joined: Fri Jul 06, 2012 7:52 pm

Re: Bug report - can't star a track

Postby hakko » Tue Mar 12, 2013 10:11 pm

Thanks!
MusicCabinet developer
hakko
 
Posts: 1416
Joined: Tue Apr 17, 2012 7:05 pm
Location: Sweden

Re: Bug report - can't star a track

Postby flvinny521 » Wed Mar 13, 2013 3:03 am

Is this the same reason that the newest Clementine release (1.1.1-433-g3e01d32) does not seem to work with MusicCabinet?


Clipboard-1.jpg
flvinny521
 
Posts: 70
Joined: Thu Jul 28, 2011 1:48 pm

Re: Bug report - can't star a track

Postby hakko » Wed Mar 13, 2013 7:08 am

I haven't looked into the requirements of Clementine, but that sounds very likely.
MusicCabinet developer
hakko
 
Posts: 1416
Joined: Tue Apr 17, 2012 7:05 pm
Location: Sweden

Re: Bug report - can't star a track

Postby obcd » Wed Apr 03, 2013 6:59 pm

About Clementine, I have tested the latest version of Musiccabinet (that uses the same REST api as subsonic4.7). Clementine connects to Musiccabinet (the id/password work), but when it comes to updating the library it does nothing.
obcd
 
Posts: 40
Joined: Mon Nov 19, 2012 2:42 pm

Next

Return to DSub for Android

Who is online

Users browsing this forum: No registered users and 3 guests