Page 1 of 2
Stuttering Playback Fix Beta 3 (Updated 3/14)!

Posted:
Wed Mar 13, 2013 3:57 am
by daneren2005
Alright, I know this has been driving people bananas for ages, but I think I might finally have a fix that piggy backs off of archrival's good work. It appears to be working flawlessly for me, but as in all things to do with Android I have no idea how it will react on others devices. So here is a beta to ensure 3 things:
1) It is actually fixed for everyone.
2) It doesn't cause the media player to wait until the file is fully downloaded before starting.
3) It doesn't break anything else or cause crashes.
Edit: Updated with Beta 3 (probably final)
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 10:47 am
by shadow.8
I'll test this today at work and let you know what I find. Looks promising!
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 5:27 pm
by mr_nobody
daneren2005 wrote:2) It doesn't cause the media player to wait until the file is fully downloaded before starting.
I briefly tested this on a gingerbread device and it did not start playing until well after all _4_ songs had finished downloading, never mind the first file.

[edit]: Are you talking about dsub itself or external video players? In any case, the above was the behaviour in dsub for music.
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 5:31 pm
by daneren2005
mr_nobody wrote:daneren2005 wrote:2) It doesn't cause the media player to wait until the file is fully downloaded before starting.
I briefly tested this on a gingerbread device and it did not start playing until well after all _4_ songs had finished downloading, never mind the first file.

Any chance you could send me a log of that happening?
Edit: and yes I am talking about music, not video
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 5:33 pm
by rubbersoul
it's working great for me on a galaxy nexus with cm10.1 M2.
i've tested it on a number of tracks and never experienced a stutter. the gapless playback is also conserved for the first track as well so basically all the playback bugs are fixed!!! Great work man, and thanks to archrival as well for working on this.
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 5:40 pm
by shadow.8
I've been testing it all this morning and it's been working really well, no skips or stutters of any kind. HTC One S running CM 10.1 (Android 4.2.2). I'm listening to music all day today during work so I'll let you know if I run into any issues.
Also, just turned on Dark Side of the Moon to test gapless playback and it worked PERFECTLY. Converted flac > ogg with no gaps and no skips. I'm loving these changes.

Thanks!
EDIT: And thanks to archrival as well!!
Re: Stuttering Playback Fix Beta!

Posted:
Wed Mar 13, 2013 6:12 pm
by mr_nobody
I will try to get a log tonight.
Re: Stuttering Playback Fix Beta!

Posted:
Thu Mar 14, 2013 12:33 am
by EdgeKun
Just like mr_nobody, I'm running into an issue of no playback until 4-5 songs have been completely downloaded to the device. This is also on a device running Gingerbread. (HTC Incredible - CM Mod 7.2.0) Aside from that, the gapless playback is working great!
Re: Stuttering Playback Fix Beta!

Posted:
Thu Mar 14, 2013 2:01 am
by hyatari
Playback is working very well on my galaxy nexus stock 4.2.2.
Re: Stuttering Playback Fix Beta!

Posted:
Thu Mar 14, 2013 3:44 am
by daneren2005
Good news, I was able to track down the two issues I'm aware of:
1) Some songs would end early and the next song would start playing along side the one already going. This was because the work around I was using was basing whether it was done or not off of a guessed file size, which was wrong in some cases.
2) GB (and probably below) devices were having a weird issue where they would just seem to hang forever. I was able to track this down to ICS+ devices properly encoding the filename without any work done by me, but apparently on older devices I needed to explicitly encode the strings. I was able to verify that it was broken on my Atrix, and that it is now working correctly.
Time for round 2, check OP for new Beta
Re: Stuttering Playback Fix Beta!

Posted:
Thu Mar 14, 2013 1:02 pm
by mr_nobody
daneren2005 wrote:Good news, I was able to track down the two issues I'm aware of:
1) Some songs would end early and the next song would start playing along side the one already going. This was because the work around I was using was basing whether it was done or not off of a guessed file size, which was wrong in some cases.
2) GB (and probably below) devices were having a weird issue where they would just seem to hang forever. I was able to track this down to ICS+ devices properly encoding the filename without any work done by me, but apparently on older devices I needed to explicitly encode the strings. I was able to verify that it was broken on my Atrix, and that it is now working correctly.
Time for round 2, check OP for new Beta
Issue #1 on my nexus 4 is resolved so that's great!
The gingerbread issue is fixed...that is, it no longer waits a long time to start playing. I am still getting occasional gaps/stutters but they are not too bad. That being said, I use all of my GB devices on wifi so the buffer=0 setting was working fine for me...but it doesn't work anymore. For some reason, it starts playing the first track 40-50 seconds in.
[edit]: Sorry, to clarify the above, it jumps to the 40-50 second mark of the track when it starts playing.
Re: Stuttering Playback Fix Beta (Updated 3/13)!

Posted:
Thu Mar 14, 2013 2:40 pm
by mr_nobody
My initial GB testing today was using the device's built in speaker. Since I've been listening on bluetooth, I haven't experienced any gaps/stutters. I'll let you know if I see them again.
Re: Stuttering Playback Fix Beta (Updated 3/13)!

Posted:
Thu Mar 14, 2013 2:49 pm
by daneren2005
Oh now that is interesting. I can verify that if you have buffer length = 0, then when it starts playing it starts playing however long it took to download the song in. I will have to investigate and get another Beta up tonight. If you don't use the buffer length option though it should work fine.
Re: Stuttering Playback Fix Beta (Updated 3/13)!

Posted:
Thu Mar 14, 2013 5:08 pm
by daneren2005
Really, I think I'm just going to get rid of the buffer length option. Does anyone use it for anything other then to get rid of stuttering? Any fix to this remaining issue is going to possibly break other fixes and require a lot of hacking fixes to get it all to work together. It seems all around safer to just remove it.
Re: Stuttering Playback Fix Beta (Updated 3/13)!

Posted:
Thu Mar 14, 2013 5:11 pm
by shadow.8
daneren2005 wrote:Really, I think I'm just going to get rid of the buffer length option. Does anyone use it for anything other then to get rid of stuttering? Any fix to this remaining issue is going to possibly break other fixes and require a lot of hacking fixes to get it all to work together. It seems all around safer to just remove it.
I sort of assumed it was going to be removed. I think that's a good idea.
