Asking for replaygain support

Alternative Android Client for Subsonic

Moderators: daneren2005, moderators

Re: Asking for replaygain support

Postby daneren2005 » Wed Sep 24, 2014 8:15 pm

The master volume just turns all of the EQ settings to max, it does not try to raise the volume above the allowed maximum. Replay Gain has to be able to lower the volume below 100%, and I don't know if there is any way to get it back up to that point.
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby gorman » Thu Sep 25, 2014 12:22 am

If you look at Vanila, it has a preamp value. Also, RG includes values related to peaks in music. You should be able to use those to limit preamp.
gorman
 
Posts: 27
Joined: Tue Sep 16, 2014 10:34 am

Re: Asking for replaygain support

Postby daneren2005 » Thu Sep 25, 2014 9:27 pm

The pre-amp doesn't make a whole lot of sense to me to be honest. If all your tags are negative or positive, it makes sense to put in the opposite so that things are as close to 100% as possible. Should that ever really happen though? I thought the whole point is sometimes they will be negative, sometimes positive. Is there a good standard that I can use instead of adding another option, or should I just make it a option with a default of 0 like Vanilla does?
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby Reith » Fri Sep 26, 2014 1:11 am

To be honest, the preamp doesn't make a lot of sense to me either, but it seems to be pretty commonplace for players that have RG support. I know foobar2000 does it also:

https://i.imgur.com/EkEfYHD.png

The adjustment for files that don't have RG tags is useful so you don't have to adjust volume as much in that scenario and then as for the ones that DO have RG tags, I assumed it was just to give more flexibility if people don't like the adjustments that the standard RG spec makes.

The principle behind ReplayGain as I understand it is to have an advanced volume knob that adjusts itself automatically to a level that is comfortable for each individual.
Reith
 
Posts: 21
Joined: Fri Sep 19, 2014 4:28 am

Re: Asking for replaygain support

Postby daneren2005 » Fri Sep 26, 2014 2:56 am

Alright, well I added both settings. It is at the same link: https://www.dropbox.com/s/6p72izbk7aaam ... 9.apk?dl=0
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby gorman » Fri Sep 26, 2014 10:45 am

Anyway, the sense of preamp is that, basically...

Ok, reference for RG is 89db. If a track stands at 89db as measured by RG, there's pretty much no way that it could clip (unless it was done on purpose).

Let's take a track that needs -10 track gain, and one that needs +4 track gain.

The one that needs -10 would measure at 99db, the other one at 85db.

If you apply a reasonable amount of preamp, let's say +3db, you still don't clip but on the other hand you don't need to raise the volume too much (which has its uses, considering you can't be sure of an amplifier power, especially when driving good quality headphones).

Also, if you look at the standard I linked in the first post, RG stores peak values as well, and those can be used to limit preamp, as to avoid clipping in any case. You might decide to ignore that and simply state to be conservative in preamp settings.
gorman
 
Posts: 27
Joined: Tue Sep 16, 2014 10:34 am

Re: Asking for replaygain support

Postby gorman » Fri Sep 26, 2014 10:46 am

By the way, the link above is broken, something with the code on the board went wrong.
gorman
 
Posts: 27
Joined: Tue Sep 16, 2014 10:34 am

Re: Asking for replaygain support

Postby daneren2005 » Fri Sep 26, 2014 5:58 pm

Sorry about that, I stupidly just copy pasted the same url from earlier in the thread. The full url is https://www.dropbox.com/s/6p72izbk7aaam ... 9.apk?dl=0

Did you have to do something special to get replay gain tags to stick after transcoding? Nothing I do seems to make them work on my end. I know that as soon as I release this, I am going to get a dozen requests on how to make it actually work with transcoding :/
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby Reith » Fri Sep 26, 2014 9:08 pm

I don't think I had to do anything special. I downloaded them and checked on my PC earlier after you posted the first test build to be sure the ReplayGain tags were actually there.

What are you using to add the tags before transcoding?
Reith
 
Posts: 21
Joined: Fri Sep 19, 2014 4:28 am

Re: Asking for replaygain support

Postby daneren2005 » Fri Sep 26, 2014 9:18 pm

I'm on Linux. I used
Code: Select all
mp3gain -a *.mp3
to add replay gain tags to a single album. I then deleted it from my phone and redownloaded it and it still says there are no tags. When using yours they show up no problem, so it is definitely something wrong with the transcoding :(
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby Reith » Fri Sep 26, 2014 9:41 pm

I believe MP3Gain is a specific implementation that actually alters the audio data.

My setup is FLAC files with RG gain tags added -> 192 CBR MP3 with the default ffmpeg transcoder.
Reith
 
Posts: 21
Joined: Fri Sep 19, 2014 4:28 am

Re: Asking for replaygain support

Postby daneren2005 » Fri Sep 26, 2014 9:48 pm

Ah, that makes sense. I will need to look for something else to use which only adds tags then. Though you both seem to have had it work without any changes, so maybe I don't need to worry about it.
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

Re: Asking for replaygain support

Postby Reith » Fri Sep 26, 2014 10:02 pm

On Windows I just scan with foobar2000. On Linux I use a bash script: https://github.com/sirjaren/redoflacs

But I think it's only for FLAC so I'm not sure what to use for mp3. I can't remember if Clementine can scan & apply RG or just read the tags.
Reith
 
Posts: 21
Joined: Fri Sep 19, 2014 4:28 am

Re: Asking for replaygain support

Postby Reith » Sun Sep 28, 2014 2:25 am

One thing I just noticed when messing around in settings that I somehow missed before:

https://i.imgur.com/m8F8hDI.png

There are two different ReplayGain checkboxes.
Reith
 
Posts: 21
Joined: Fri Sep 19, 2014 4:28 am

Re: Asking for replaygain support

Postby daneren2005 » Sun Sep 28, 2014 4:13 am

Lol good catch. I will remove the duplicate one

Sent from my Nexus 5 using Tapatalk
Developer of DSub for Android
daneren2005
 
Posts: 1704
Joined: Fri Jul 06, 2012 7:52 pm

PreviousNext

Return to DSub for Android

Who is online

Users browsing this forum: No registered users and 2 guests