Disabling Online Lyrics Search Chartlyrics

Need help? Post your questions here.

Moderator: moderators

Disabling Online Lyrics Search Chartlyrics

Postby pemholder » Fri Dec 01, 2017 10:27 am

I appreciate it very much, that since some time Subsonic is able to show lyrics in the way I requested it some years ago:
1. Look for embedded lyrics in the tag UNSYNCEDLYRICS
2. If no lyrycs are embedded look online for lyrics

I invested a lot of work in the past to get my lyric-tags locally filled, and if they are not filled now, Subsonic will not find the correct lyrics on Chartlyrics anyway.
It is very annoying that Subsonic very often shows lyrics that have nothing to do with the song at all. The online-search ist much too tolerant and therefore delivers the wrong results.

So I am interested in a way to disable the online-search for lyrics and show only local results.
I had a look at the lyrics.js-file but my knowledge in coding is not good enough to comment out part of the code to get the desired result, if this is the right file anyway.

Is anyone able to tell me what I have to change and if the changes to make are accessable?
pemholder
 
Posts: 73
Joined: Wed Dec 09, 2009 1:28 pm

Re: Disabling Online Lyrics Search Chartlyrics

Postby MasterCritics » Wed Dec 06, 2017 7:43 am

I was just doing some troubleshooting to get my lyrics fixed up and I've found that it might have something to do with multiple files of the same name and reading from strings.

So if you've noticed, when the Subsonic server searches for lyrics it uses the Artist Name and Song Title as its search terms. What I think happens after that is it picks the first one which comes up.

So let's say these are the songs in question, and the lyrics are placed in one of them, as shown below:

深い森 - Do As Infinity - DEEP FOREST
深い森 - Do As Infinity - Do The A-side Disc One - *LYRICS*
深い森 - Do As Infinity - The Best of Do As Infinity

When Subsonic does the search, it searches for "Song Title: 深い森 and "Artist: Do As Infinity", and eventually comes up with the results shown above, in that order. It then picks the first one to view the lyrics, and since I didn't insert lyrics into that file, no lyrics results are shown, and Subsonic falls back on the next best thing: Chartlyrics.

The problem is probably easily enough solved if the search includes album title, but on our end we can just simply insert lyrics data into all the songs with the exact same title and artist name within the same library.

The second issue I've found is how it reads the string. I've found out that the lyrics search craps up when it tries to read "-" and "&".

For example:

We wanna R&R SHOW - GRANRODEO -> Lyrics don't show
We wanna RnR SHOW - GRANRODEO -> Lyrics show

...and...

Until -from Hispania- - 上原れな -> Lyrics don't show
Until ~from Hispania~ - 上原れな -> Lyrics show (note the change from "-" to "~")

So that one's pretty screwed up, but we can still circumvent it if we take the trouble to change the song title. Not sure yet if it affects artist names, but I assume it will.

Finally, is one I'm still unable to figure out.

I have two completely different tracks with similar names:

星座 - Suara -> Lyrics don't show
星座 Pure version - Suara -> Lyrics show

But if I change "星座" to some other title, it works. It's as though Subsonic assumes there is no string data when "星座" is input as a search, but it makes no sense whatsoever because it works for the other songs which are also completely in Chinese. It could be an issue with unicode, maybe? I'm really not sure at this point.

It'll be great if anyone could build on this.
MasterCritics
 
Posts: 2
Joined: Wed Dec 06, 2017 6:49 am

Re: Disabling Online Lyrics Search Chartlyrics

Postby pemholder » Wed Dec 06, 2017 8:39 am

MasterCritics wrote:So if you've noticed, when the Subsonic server searches for lyrics it uses the Artist Name and Song Title as its search terms. What I think happens after that is it picks the first one which comes up.

Hm, I am not quite sure if I understand you right.
So far I have assumed that Subsonic - if it looks up locally in the unsyncedlyrics tag - does not use a search, because it knows exactly in which file it must look and only the content of the unsyncedlyrics tag has to be displayed.
Other approaches would also be nonsensical and incomprehensible. I also can not remember ever having gotten the wrong result in such a case where the unsyncedlyrics tag was read.
If you are only referring to the search in Chartlyrics, I can mentally understand what you have determined.

With regard to my music collection at the moment I can not see any sense in looking for lyrics at Chartlyrics anyway.
As I wrote before, my music files, as far as I could fetch the the lyrics at all, have meanwhile embedded all the lyrics in the unsyncedlyrics tag. The chance that in Chartlyrics some additional lyrics are found, almost goes to zero.
So it is very annoying that in such cases (missing unsyncedlyrics tag information) Subsonic simply displays Chartlyric's fake lyrics.
In such cases, I would prefer that no lyrics are displayed at all ("No Lyrics found").

So I'm still looking for a way to change the subsonic code so that Subsonic looks only locally in the unsyncedlyrics tag.
The best solution would be, of course, if in the settings of Subsonic such an option would be selectable.
pemholder
 
Posts: 73
Joined: Wed Dec 09, 2009 1:28 pm

Re: Disabling Online Lyrics Search Chartlyrics

Postby toolman » Wed Dec 06, 2017 10:41 am

No solution but a workaround may be to go to settings >> Personal and unmark Show what others are playing
In that way the option to show the lyrics disappears.
toolman
 
Posts: 377
Joined: Fri Dec 11, 2009 4:18 pm
Location: Netherlands

Re: Disabling Online Lyrics Search Chartlyrics

Postby pemholder » Wed Dec 06, 2017 11:23 am

toolman wrote:No solution but a workaround may be to go to settings >> Personal and unmark Show what others are playing
In that way the option to show the lyrics disappears.

I won't call that a workaround. A workaround is something to achieve a goal in a non direct way.
Disabling the possibility to see lyrics in Subsonic at all in order to achieve not seeing the wrong lyrics in some cases is definitely not the goal.
I want to see the lyrics, otherwise I would not have embedded them in the files.
pemholder
 
Posts: 73
Joined: Wed Dec 09, 2009 1:28 pm

Re: Disabling Online Lyrics Search Chartlyrics

Postby toolman » Wed Dec 06, 2017 1:35 pm

Ok, sorry, Just trying to help.
Good luck with your lyrics.
toolman
 
Posts: 377
Joined: Fri Dec 11, 2009 4:18 pm
Location: Netherlands

Re: Disabling Online Lyrics Search Chartlyrics

Postby MasterCritics » Thu Dec 07, 2017 2:12 am

For it to return lyrics data, Subsonic first has to know which file it is looking for.

Problem is, it does so by doing a sort of "generalized search" instead of referring directly to the file that you indicated you wanted to see your lyrics on. This search points Subsonic to the FIRST file it finds with its search terms, then Subsonic returns lyrics from THAT file. The biggest flaw of this blanket approach is, as you can guess, that it can point to the wrong file. And I can't even fathom how it processes the search; I've seen it point to completely unrelated songs before.

If you already have embedded lyrics and Subsonic can find them, then it will use them. Chartlyrics is utilized only as a last resort.

I didn't look through any code when doing this, just painful trial and error by messing with Subsonic's lyrics search terms and changing the names of my songs locally.

It's really dumb, especially when you consider that Subsonic's string searching is riddled with problems, especially when non-English characters are involved.

And I might have misunderstood your problem as well. If you wanted Subsonic to look only into the UNSYNCEDLYRICS tag locally, might it be possible to instead just disable the search into Chartlyrics instead? After all, it's probably an if-else statement somewhere in that code.
MasterCritics
 
Posts: 2
Joined: Wed Dec 06, 2017 6:49 am

Re: Disabling Online Lyrics Search Chartlyrics

Postby pemholder » Thu Dec 07, 2017 6:06 am

MasterCritics wrote:Problem is, it does so by doing a sort of "generalized search" instead of referring directly to the file that you indicated you wanted to see your lyrics on.

I did not know this and was expecting that if Subsonic already knows the file to look in, it would do so directly and to find lyrics in the unsyncedlyrics tag would not include a search.

And I might have misunderstood your problem as well. If you wanted Subsonic to look only into the UNSYNCEDLYRICS tag locally, might it be possible to instead just disable the search into Chartlyrics instead? After all, it's probably an if-else statement somewhere in that code.


Yes, that is my intention as long as there is no option for disabling "the last resort Chartlyrics".
viewtopic.php?f=3&t=17746
Therefore I looked into the code but I can not find the responsible code snippet in lyrics.jsp. The search may be included in the call of a function and my code understanding is very very basic.

So far I have not been able to determine in practice that Subsonic incorrectly selects locally existing lyrics. That may be because the chance of Subsonic finding the right lyrics on filled unsyncedlyrics tag is bigger than looking at Chartlyrics. So far, I only noticed bad results when it was really necessary for Subsonic to look at Chartlyrics.
Therefore, regardless of the possibly erroneous assignment even with locally existing lyrics, I am interested in stopping the search in Chartlyrics, because in any case, all that is worth to find is already embedded in my files.
pemholder
 
Posts: 73
Joined: Wed Dec 09, 2009 1:28 pm


Return to Help

Who is online

Users browsing this forum: No registered users and 6 guests