BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST API

Need help? Post your questions here.

Moderator: moderators

BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST API

Postby rich600 » Tue Nov 20, 2018 5:28 pm

Hi

with the addition of artistImageUrl to Artist & ArtistID3, if it cannot find an matching artist, the name of the artist is also not returned.

This means that a call to getIndexs returns data like :

Code: Select all
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.16.1">
  <indexes lastModified="1542733356942" ignoredArticles="The El La Los Las Le Les">
    <index name="A">
      <artist id="51813" name="Albert Collins" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/e7c5c0996c034e3a8555f6233597058e.png"/>
      <artist id="51894" name="Albert King" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/7888953da5e9459d82e41f01a015a8e5.png"/>
      <artist id="51942" name="Al Green" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/8d18ca5108d31fbd71cf9797a948fbca.png"/>
      <artist id="156187"/>
      <artist id="51890"/>
      <artist id="51902" name="Aretha Franklin" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/e82a669b0f9d4834c8e957b17fbc9f45.png"/>
    </index>


It doesn't make sense that artists wouldn't have a name.

Thanks
Rich
rich600
 
Posts: 132
Joined: Tue Aug 12, 2014 9:54 pm

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby Michael Bech Hansen » Tue Nov 20, 2018 9:22 pm

Hi,

I dont find this to be the case...
Both my own server and the demo.subsonic.org return names for all artists regardless of the presence/absence of artistImageUrl:

Code: Select all
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.16.1">
    <indexes lastModified="1542580655000" ignoredArticles="The El La Los Las Le Les">
        <index name="A">
            <artist id="314" name="ABC" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/3011eac0413e3bc0e2afa3d33464c46a.png"/>
            <artist id="402" name="ACDC" artistImageUrl="https://lastfm-img2.akamaized.net/i/u/300x300/7c8e775c68a94c239e8056290a3eb3d3.png"/>
            <artist id="36206" name="Adam Cohen"/>
            <artist id="219" name="Adam Gussow, Sterling Magee"/>


Cheers,
Michael.
Developer of play:Sub for iOS.
https://geo.itunes.apple.com/us/app/play-sub-subsonic-music-streamer/id955329386?mt=8
User avatar
Michael Bech Hansen
 
Posts: 72
Joined: Thu Mar 26, 2015 4:12 pm

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby acroyear » Tue Nov 20, 2018 10:56 pm

Maybe the difference is if the Artist is actually an Artist in ID3 as well.

E.g., I have some Music Folders that are 'pure' - standard 2-level, index->artist->album, such that getIndexes and getArtists are almost the same.

I have others where I have a much more complicated deep nesting, where the "artists" in the indexes aren't but rather categories. E.g., my Rock AOR section has top levels of "ELP" and "Pink Floyd and Friends" and "The Who and Friends", and within those I then have the real artists so ELP has folders of Emerson Lake Palmer, Emerson Lake Powell, Greg Lake, and 3. Same for the others, incorporating the solo works but keeping them grouped.

As such, "Pink Floyd and Friends" isn't really an artist in my database at the ID3 level. So maybe, by not being an actual artist associated with a song in ID3 in some file, that's why it isn't returning the names properly?

So rich600 - what are the artists/music directories that are missing the name? Do they fit this pattern?

I'll see about installing 6.1.4 on a box and giving it a test this holiday weekend.
--
Joe Shelby
http://subfiresuite.com/
http://subfireplayer.net/
User avatar
acroyear
 
Posts: 592
Joined: Wed Mar 27, 2013 8:05 pm
Location: Northern, VA

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby rich600 » Wed Nov 21, 2018 2:42 pm

Hi,

the folders in the example that aren't returning names are called :

algreen2005-09-18-flac
Amy Winehouse - 2004-The Hague, Netherlands

Acroyear I think you might have been on to something. If not found in LastFM, its not returning the name.

Thanks
Rich
rich600
 
Posts: 132
Joined: Tue Aug 12, 2014 9:54 pm

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby jm_fr » Wed Nov 21, 2018 9:14 pm

Same issue in Subsonic 4.8 (Android APP) since 6.1.4 update.
Some artists are indexed by their folder name on the server, some others artists are indexed by the id3 tag of the .mp3 files. Some artists are indexed by ther id3 tag of the first file of the Artist folder : i.e. if the "artist id3 tag" of the first mp3 file ("the girl is mine.mp3") in the folder "Thriller" is "Michael Jackson featuring Paul McCartney" so all the .mp3 of this LP will be associated to the artist "Michael Jackson featuring Paul McCartney" : however all the others .mp3 files of this LP have an artist id3 tag "Michael Jackson"
In the app, the library tab is a real mess, which no longer respects the alphabetical order and with many names of empty artists.

There is no SHA256 digests for 6.1.4 version in https://s3-eu-west-1.amazonaws.com/subsonic-public/download/checksums-sha256.txt
jm_fr
 
Posts: 2
Joined: Sat Sep 22, 2012 8:03 pm

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby rich600 » Thu Nov 29, 2018 10:06 am

I've submitted a patch for AVSub to address this problem.

Cheers
Rich
rich600
 
Posts: 132
Joined: Tue Aug 12, 2014 9:54 pm

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby sindre_mehus » Sat Dec 01, 2018 10:47 am

I can confirm that this is a bug introduced in 6.1.4. I will provide a fix within a day or two.

Sorry for the inconvenience!
Sindre
Subsonic developer
User avatar
sindre_mehus
 
Posts: 1954
Joined: Tue Nov 29, 2005 6:19 pm
Location: Oslo, Norway

Re: BUG - 6.1.4 breaks getIndexes/artist/artistID3 in REST A

Postby rich600 » Tue Dec 04, 2018 9:26 am

Hi Sindre,

Thanks for this - I can confirm that 6.1.5 has fixed the problem.

Keep up the great work!

Cheers
Rich
rich600
 
Posts: 132
Joined: Tue Aug 12, 2014 9:54 pm


Return to Help

Who is online

Users browsing this forum: No registered users and 8 guests