Bug when displaying artist page with non-album folders
Posted: Tue Jan 08, 2019 5:26 pmI'm not 100% sure that it is the right place for that post, so I apologize in advance if it's not.
I think I've just noticed a small bug.
Let's say an artist's page contains 42 folders, 33 of which are albums, 9 of which are non-albums folders.
At the moment, Subsonic will hide the two last albums but won't display the "Show all albums" button.
The reason for that can be found in the artistMain.jsp file at line 244.
The loop starting at line 241 goes through every folder contained in the artist's folder to display the albums, but it stops to display the albums' cover not after the 39th album but after the 39th folder.
On the other side, the "Show all albums" only appears it there is more than 39 albums. So if there's more than 39 folders but less than 39 albums, some albums may be hidden without any way to access them.
This problem seems to be solved by changing the following line:
to
I think I've just noticed a small bug.
Let's say an artist's page contains 42 folders, 33 of which are albums, 9 of which are non-albums folders.
At the moment, Subsonic will hide the two last albums but won't display the "Show all albums" button.
The reason for that can be found in the artistMain.jsp file at line 244.
The loop starting at line 241 goes through every folder contained in the artist's folder to display the albums, but it stops to display the albums' cover not after the 39th album but after the 39th folder.
On the other side, the "Show all albums" only appears it there is more than 39 albums. So if there's more than 39 folders but less than 39 albums, some albums may be hidden without any way to access them.
This problem seems to be solved by changing the following line:
- Code: Select all
<div class="albumThumb" style="display:${loopStatus.count < 40 ? 'inline-block' : 'none'}">
to
- Code: Select all
<div class="albumThumb" style="display:${albumCount < 40 ? 'inline-block' : 'none'}">