Hi Sindre!
sindre_mehus wrote:Hi,
I guess there are three reasons why I haven't included this in the official release:
o I haven't had much time to look at it

o I think the number of users who need this functionality is fairly low. Subsonic is already quite complex, and all new features must be cost-effective in terms of implementation and ease-of-use.
I don't know how common subsonic is used among groups of people.
Subsonic is complex but you documented it very good. I've seen a lot of sourcecode from other Open Source projects and your code is one of the best documented I've seen (otherwise it would have been harder to add this functionality).
Well the cost was my time adding this feature + creating patches since release 3.50b1 and it's easy to use.
The rest you have to decide.
As I said you'll get the updated patches and sourcecode (source unchanged since Aug. 2008) shortly after I completed the final test (most likely this evening).
Testing it is easy and might be interesting for other people:
Just copy the currenct subsonic sources to another directory extract my source archive in the root directory of you subsonic sourcecode.
Copy the *.diff there and apply the diff (using: patch -p0 -i <name_of_diff.diff>).
Finally running "mvn package" and there is the *.war file.
You should create a backup of the current HSQLDB database file as I add a new role and table for the extended search server configuration.
A readme.txt is include in the new package which is describing every step creating a modified subsonic with the extended search feature.The database configuration is also my main concern when it commes to further updates when the source is not integrated into your code.
Thank god so far there was no update to the user roles otherwise there would be a little problem because the RoleId while updating from one subsonic version to the next.
Beside that the DaoHelper needs to be updated manually between the releases (in most cases).
sindre_mehus wrote:o It's not very useful yet. You can't do anything with the extended search result.
Yes, you can't download the files directly but it's still very useful.
If several friends also run their subsonic you can search them directly while accessing your own subsonic and don't have to login on each of your friends subsonic.
Because of the missing "direct" download/stream option you then have to login at the other webservers.
The download link (the link was something encoded using the local file path if I recall correctly) could be added to the XML response but I'm not sure if that's all that is needed. The link is not for the Subsonic you are currently logged in but another one.
Will there be a popup asking for the login if you call the distant Subsonic with the encoded local file path?
For streaming this should be simmilar but I don't recall how this is handled as I haven't looked into the code since 6 month.
sindre_mehus wrote:Please don't interpret this as a disencouragement. I just don't feel that it's right to include it in the main baseline as the current state.
Thanks,
Sindre
This basically comes down to:
Add the direct download possibility and I'll add your code.
