Android Bug: App loops if directory has a ':' in the name

Got an idea? Missing something? Post your feature request here.

Moderator: moderators

Android Bug: App loops if directory has a ':' in the name

Postby ccandreva » Sat Sep 04, 2010 12:35 am

Some people have reported the Android app causing a large server load, and I may have figured out why.

I've found that if you try to load files where there is a ":" (colon) character somewhere in the path, the app never downloads anything, but goes into a loop starting many connections to the server. This is the cause of the load.

This seems to only be an issue in the Android app, as the same files play with the same transcoders fine through the jukebox and web players.
User avatar
ccandreva
 
Posts: 104
Joined: Fri May 28, 2010 8:22 pm

Postby nullchar » Tue Nov 16, 2010 6:27 am

Like you suspected, this is a limitation of the FAT filesystem that Android uses. See the character exclusions here:

http://en.wikipedia.org/wiki/File_Allocation_Table#Directory_table

It is a bummer the colon ":" character can't be used as it exists in many of my podcast directories and filenames. I wonder how difficult it would be for the android app to replace ":" with "-" when it write the file to disk cache.
nullchar
 
Posts: 9
Joined: Tue Nov 16, 2010 5:13 am
Location: Idaho, US

Postby sanods » Mon Nov 22, 2010 9:14 am

nullchar wrote:It is a bummer the colon ":" character can't be used as it exists in many of my podcast directories and filenames. I wonder how difficult it would be for the android app to replace ":" with "-" when it write the file to disk cache.


That would be the proper solution and should be pretty easy, its a matter of always converting the filename in the same way when reading from the disk.
sanods
 
Posts: 8
Joined: Thu Nov 11, 2010 1:37 pm
Location: SE

Fixed!

Postby nullchar » Mon Jun 20, 2011 5:17 am

My patch was accepted and this issue is fixed! (The full FAT exclusions were applied.)

I can now stream music from my linux box with ":" in the path to my android phone.

(This enables me to stream a lot of NPR podcasts, as they often have colons in the path, at least when podcasted from Rhythmbox.)
nullchar
 
Posts: 9
Joined: Tue Nov 16, 2010 5:13 am
Location: Idaho, US


Return to Feature Requests

Who is online

Users browsing this forum: No registered users and 8 guests