Page 1 of 4

Subsonic 4.9.beta4 released

PostPosted: Sat Jan 04, 2014 8:54 pm
by sindre_mehus
Sorry for all the betas - this is hopefully the last!

New: Support playlist sharing on Facebook etc.
New: Added "Play next" button to playlist view.
New: Added "Play all" to starred songs.
New: Added "Save as playlist" to starred songs.
New: Show cover art for starred albums.
New: Show album/song count in genre list.
New: When playing a song from a playlist, queue other songs in that playlist.
New: When clicking the play icon for a song, add whole album to play queue.
New: Clicking on album thumb in "Now playing" now opens album page.
New: Cache generated album art.
Bugfix: Don't create zip file when downloading a single song.
Bugfix: Show cover art in the right order.
Bugfix: Hande genres names with special characters (e.g., "R&B").
Bugfix: Fixed character encoding problems in some translations.
Bugfix: Use locale-specific names for automatically created playlists.
REST: Added album/song count in getGenres.

Happy new year, everybody!
Sindre

Re: Subsonic 4.9.beta4 released

PostPosted: Sun Jan 05, 2014 1:41 am
by OlYeller21
Thanks for your hard work, Sindre.

Re: Subsonic 4.9.beta4 released

PostPosted: Sun Jan 05, 2014 2:46 pm
by baaldemon
Definitely a move back in the right direction with the download function. However there is still a horrible user workflow to download a single song, especially coming from previous versions where this action was a single click. The top download link is called "Download" not "Download All" which is the functionality that it actually provides. This once again is still rather confusing for the end user and leaves them in a state of questioning when trying to download a single file as there is no clear design that shows them how to do this. It seems like there is more than enough space to accomodate 4 buttons rather than just 3, meaning you could continue to have a download button even while adding the play next. Is there a reason why you are pushing so hard to remove the basic one click single file download functionality when it seems you can keep this while adding the new functionality that you are trying to put in place?

Re: Subsonic 4.9.beta4 released

PostPosted: Sun Jan 05, 2014 5:07 pm
by phazzard
Ever since updating to beta4 I have been unable to get the network setup to work - XXX.subsonic.org returned HTTP error code 404 Not Found. I have not had this issue with any previous revision and it only started being a problem when I installed the beta4. My port forwarding is set up properly within my netgear router, I even tried changing to a new random port, stopping and restarting services, and I am still getting the same message. I am able to use Subsonic on my local machine (And I love the new updates, thank you), but I am no longer able to access from outside my home? Any ideas?

Re: Subsonic 4.9.beta4 released

PostPosted: Sun Jan 05, 2014 8:36 pm
by mbro
Thanks, Sindre for your hard work. LOVE subsonic!

Just updated to 4.9 beta 4. Using the regular web UI, trying to play back in jukebox mode, the "play" link wants my browser to download "play.m3u" play list, instead of actually play back music. Expected behaviour, or a bug?

Re: Subsonic 4.9.beta4 released

PostPosted: Mon Jan 06, 2014 2:11 am
by madsenmi
I agree with everyone that beta4 is another step in the right direction however I am still having an issue whenever a user downloads a video file from me it is automatically zipped. Would love to see this removed as this was not a regular function in 4.8 and below.

Re: Subsonic 4.9.beta4 released

PostPosted: Mon Jan 06, 2014 12:47 pm
by baaldemon
madsenmi wrote:I agree with everyone that beta4 is another step in the right direction however I am still having an issue whenever a user downloads a video file from me it is automatically zipped. Would love to see this removed as this was not a regular function in 4.8 and below.

How are your users downloading? When I tested out the functionality before adding the download button back in the download process for a single file was working without zipping. Also if you want to add the download button back in append the following code to playButtons.jsp
Code: Select all
<c:if test="${param.asTable}"><td></c:if>
<c:if test="${(empty param.downloadEnabled or param.downloadEnabled)}">
    <a href="/subsonic/download.view?id=${param.id}">
        <img src="<spring:theme code="downloadImage"/>" alt="<fmt:message key="common.download"/>"
             title="<fmt:message key="common.download"/>"></a>
</c:if>
<c:if test="${param.asTable}"></td></c:if>

Re: Subsonic 4.9.beta4 released

PostPosted: Mon Jan 06, 2014 12:56 pm
by madsenmi
Thank you so much for the source code to add the button back, I will meddle around with that after work today. Currently my user's are selecting the "Download" namestring button which is still automatically zipping up any of my video file's that are not originally in compressed form. I have cleared java cache and restarted my host running subsonic services to ensure it's not a caching issue.

Re: Subsonic 4.9.beta4 released

PostPosted: Mon Jan 06, 2014 2:03 pm
by baaldemon
When you say the download namestring button, not quite sure what you are referring to. The issue I was having was that the users would select the Download link at the top of the main frame rather than selecting the action from the more actions drop down at the bottom of the page. The difference being that the top download link works on trying to download everything in the directory whereas the download action from the dropdown should only download what is selected, and with one file selected im showing that its properly not zipping.

Just make sure you clarify with the users which "download" option they are performing because it is not clear whatsoever that the different workflows do different things.

Re: Subsonic 4.9.beta4 released

PostPosted: Mon Jan 06, 2014 2:23 pm
by madsenmi
Thank you Baaldemon! This is exactly what I was looking for, users were selecting the download link, the dropdown download option is unzipped!. By re-adding the Download button I should be all set! Thanks for the help

Re: Subsonic 4.9.beta4 released

PostPosted: Tue Jan 07, 2014 2:39 am
by baaldemon
So I cant tell for sure if this is a new issue or not, but the first I've seen it in my logs is when I originally installed 4.9beta3, and its happening with 4.9beta4 as well.
Error being written out is (note Ive modified the logger to treat errors differently:
Code: Select all
[2014-01-06 03:45:46,143] WARN JaudiotaggerParser - Error when parsing tags in <pathToFile> - see subsonic.err for full details

and full stack trace is:
Code: Select all
[2014-01-06 03:48:41,412] WARN JaudiotaggerParser - Error when parsing tags in <pathToFile> - see subsonic.err for full details
org.jaudiotagger.audio.exceptions.CannotReadException: Unable to read file because it is too small to be valid audio file: <pathToFile>
        at org.jaudiotagger.audio.generic.AudioFileReader.read(AudioFileReader.java:90)
        at org.jaudiotagger.audio.AudioFileIO.readFile(AudioFileIO.java:285)
        at org.jaudiotagger.audio.AudioFileIO.read(AudioFileIO.java:148)
        at net.sourceforge.subsonic.service.metadata.JaudiotaggerParser.getRawMetaData(JaudiotaggerParser.java:74)
        at net.sourceforge.subsonic.service.metadata.MetaDataParser.getMetaData(MetaDataParser.java:47)
        at net.sourceforge.subsonic.service.MediaFileService.createMediaFile(MediaFileService.java:436)
        at net.sourceforge.subsonic.service.MediaFileService.checkLastModified(MediaFileService.java:127)
        at net.sourceforge.subsonic.service.MediaFileService.getChildrenOf(MediaFileService.java:197)
        at net.sourceforge.subsonic.service.MediaScannerService.scanFile(MediaScannerService.java:228)
        at net.sourceforge.subsonic.service.MediaScannerService.scanFile(MediaScannerService.java:232)
        at net.sourceforge.subsonic.service.MediaScannerService.scanFile(MediaScannerService.java:232)
        at net.sourceforge.subsonic.service.MediaScannerService.doScanLibrary(MediaScannerService.java:178)
        at net.sourceforge.subsonic.service.MediaScannerService.access$000(MediaScannerService.java:48)
        at net.sourceforge.subsonic.service.MediaScannerService$2.run(MediaScannerService.java:147)


So im not sure if you just changed the exception handling for CannotReadExceptions but these errors only started happening with 4.9beta3. Note the read permission issues have existed on these files since before I built this server (files are mounted over nfs and previous server used the same mounts) and I have not seen these errors before. Since I havent seen these before and I know the permission issues have existed for multiple years I am assuming that their existence starting in the 4.9beta3 logs is because of a change. I will look further into the code once I get more time. Additionally the CannotReadException text is a bit misleading because it states the file is too small to read, but at least in my case that is not the case. The file is simply not readable rather than being too small to read.

Note I am running openSuse 12.2 x86_64 with tomcat6 using a war file compiled with openJDK 1.7.0_45

Re: Subsonic 4.9.beta4 released

PostPosted: Tue Jan 07, 2014 9:53 am
by HippopoKiboko
The download function still not working with Unicode Characters in File name... :(
viewtopic.php?f=2&t=1424&start=15#p59187

Re: Subsonic 4.9.beta4 released

PostPosted: Wed Jan 08, 2014 9:48 am
by joost
Looks like the special characters issue isn't fixed in beta 4 here. I'm on debian 6, tomcat 6 and java7.

Upnp server crashes or is not reachable.
I've tried the following clients:
XBMC frodo 12.3 on os x 10.7 and windows 7: when reachable not able to play files, many times not browsable also.
XBMC gotham dev build: same result.
VLC on Windows 7 and os x 10.7: Sometimes a song plays, other songs don't. Very random behaviour.
Foorbar (windows 7): When it works, it does well. After that not reachable.
On ios mediaconnect the upnp is working and I can play songs.

Love the new functionality. The auto album art is a nice feature and new theme also nice. Thanks for the hard work on this update!!!!

Re: Subsonic 4.9.beta4 released

PostPosted: Wed Jan 08, 2014 3:57 pm
by demodulated
Many thanks for your hard work. Your software makes me very happy!

Re: Subsonic 4.9.beta4 released

PostPosted: Wed Jan 08, 2014 5:51 pm
by sindre_mehus
baaldemon wrote:Definitely a move back in the right direction with the download function. However there is still a horrible user workflow to download a single song, especially coming from previous versions where this action was a single click. The top download link is called "Download" not "Download All" which is the functionality that it actually provides. This once again is still rather confusing for the end user and leaves them in a state of questioning when trying to download a single file as there is no clear design that shows them how to do this. It seems like there is more than enough space to accomodate 4 buttons rather than just 3, meaning you could continue to have a download button even while adding the play next. Is there a reason why you are pushing so hard to remove the basic one click single file download functionality when it seems you can keep this while adding the new functionality that you are trying to put in place?


Thanks for the feedback! The rationale for removing the explicit download button is:

1. Having six controls next to each other (for each song) is too much, in my opinion.
2. It's (presumable) much less frequently used than the other buttons for playing/queuing songs.

Based on your comments, I have now done two minor changes that hopefully make the interface less confusing: The "Download" link is renamed to "Download all", and the "More actions..." drop-down is renamed to "Selected songs..."

Regards
Sindre