Subsonic Forum

Hi,

I've wrote few patches for android client (the first one is re-patched 2.8 Screen On (press menu key in the player screen) plus screen option icon, you can tell by the looks of that icon that I shouldn't do art ).

http://namai.vitiho.com:4444/screen-on- ... -2.8.patch
http://namai.vitiho.com:4444/ic_menu_screen_option.png

Also I've added ability to queue songs next instead of always going last (long click a song or long click queue button).

http://namai.vitiho.com:4444/queue-next ... -2.8.patch

And last one is to scroll to current playing song (which I think should happen any time you click playlist, personally for me it makes more sense)

http://namai.vitiho.com:4444/scroll-to- ... -2.8.patch

Combined binary is here:

http://namai.vitiho.com:4444/Subsonic.apk

@nesvarbu, that's awesome! i hope Sindre can include these patches in the next release; i'll +1 if that helps

cxc4u wrote:@nesvarbu, that's awesome! i hope Sindre can include these patches in the next release; i'll +1 if that helps

Thanks, hopefully he'll have time for that, I've noticed 2.9 TODO is big as it is
Meanwhile I've added another patch (binary is updated accordingly), this one is for swipe... left to right does the next song, right to left previous one (You know if you're driving):

http://namai.vitiho.com:4444/swipe-subsonic-2.8.patch

@nesvarbu, this sounds terrific! I'll review your patches and add them to the next release.

Thanks a lot for sharing!
Sindre

sindre_mehus wrote:@nesvarbu, this sounds terrific! I'll review your patches and add them to the next release.

Thanks a lot for sharing!
Sindre

Great! Thanks!
I've updated the swipe patch by adding listeners to albumArtImageView, buttons and etc as it wasn't swiping on albumart or buttons.

I've also noticed in 2.9 you have this on TODO list:

TODO wrote:Shuffle play turned back on when rotating phone. (onNewIntent?)

I've noticed the same issue with my Screen ON option, it gets reset on change of orientation (some people might call it as a feature, as when you exit your car, you'll move your phone and subsonic would reset to not keeping the screen on, but it's as it's unintended I'd count it as a bug). It's easily fixable if you change AndroidManifest.xml from:

AndroidManifest.xml wrote: <activity a:name="net.sourceforge.subsonic.androidapp.activity.DownloadActivity"
a:configChanges="keyboardHidden"
a:launchMode="singleTask"/>

to:

AndroidManifest.xml wrote: <activity a:name="net.sourceforge.subsonic.androidapp.activity.DownloadActivity"
a:configChanges="orientation|keyboardHidden"
a:launchMode="singleTask"/>

All other activities already had orientation added so I am not sure if it was intentionally left out on DownloadActivity.

Hi,

I can't reach your server now, is it down?

"orientation" is intentionally left out from DownloadActivity because it uses different layouts in portrait and landscape mode.

I'll see if there's another way to fix it once I get the patch.

Later,
Sindre

ah, I haven't noticed that layout is a bit different when I tested it
I guess you may need to override onconfigchange method
Not as easy as I thought

Meanwhile I've updated screenOn patch (to save the variable in downloadservice) so now you don't loose your setting on orientation change.

As for the server it should be fine (runs on non standard port, but I was able to access it)?