[bug] Not all tag selections on tag configuration page saved

[pw22]

First - fantastic mod to a great program. I am extremely thankful for your great work!

My installation seems to have a bug whereby not all of the selections on the tag configuration page are saved when you hit "Save". For instance, I can't get it to keep "Rock" selected. On the other hand it seems fine with "techno". There's a real mix of which ones will work and which ones won't, although if I hit "Mark All" (it initially correctly marks them all) and then "Save", it only saves the marks to the first 30 or so genres listed alphabetically but leaves the remainder (with the exception of some of the ones further down the list that it has previously saved, e.g. "techno"). I've checked both subsonic.log and musiccabinet.log for any error messages around the time of the unsuccessful save, but there's nothing.

Any ideas?

In case it is relevant, I have a fairly large collection (>100k tracks).

Kind regards

pw22

[jake-]

First - fantastic mod to a great program. I am extremely thankful for your great work!

My installation seems to have a bug whereby not all of the selections on the tag configuration page are saved when you hit "Save". For instance, I can't get it to keep "Rock" selected. On the other hand it seems fine with "techno". There's a real mix of which ones will work and which ones won't, although if I hit "Mark All" (it initially correctly marks them all) and then "Save", it only saves the marks to the first 30 or so genres listed alphabetically but leaves the remainder (with the exception of some of the ones further down the list that it has previously saved, e.g. "techno"). I've checked both subsonic.log and musiccabinet.log for any error messages around the time of the unsuccessful save, but there's nothing.

Any ideas?

In case it is relevant, I have a fairly large collection (>100k tracks).

Kind regards

pw22

Omg i'm not alone with this error. Hakko invested a lot of time already but without success.

[hakko]

I've been looking into this some more and the only input I can come up with right now is this:

The handling of corrected tags also affects what's being used in your tag cloud. Maybe this should be changed? Right now, I have for example entered that "hip-hop" is a correction for "hip hop". This is interpreted so that the tag "hip hop" will never go into my tag cloud, while "hip-hop" always will.

Even if I mark the "hip hop" tag and unmark "hip-hop" and press save, they'll come out with "hip hop" unmarked and "hip-hop" marked, because I've entered "hip-hop" as correction for "hip hop".

Now if you have a whole lot of corrections entered (like jake- has), this means that you automatically get all those corrected tags put into your tag cloud. I imagined people would just correct popular misspellings of their favorite tags and then this is helpful. But maybe it's inflexible having it like that?

I'd also like to ask pw22 specifically:
- does your tag say "Rock", or "rock"? Tags are supposed to always be lower-case, so I'm wondering if an upper-case tag has somehow made it into your library.
- have you entered a tag correction for "rock"?
- when you do the mark all thing and press save, which is the last tag that is getting saved as marked? and which one is the first one that isn't saved?
- also, which version are you running? I've released a couple of different versions to identify why it fails for jake- and they all behave slightly differently.

[pw22]

Interesting...

The first tag not to save is "e-l-e-c-t-r-o". I just tried changing the "Corrected Tag" for that field to "electro" and it also won't save the corrected tag for "e-l-e-c-t-r-o".

In response to your questions:
* rock is lowercase
* the last tag saved is "dutch" and the first tag unsaved is "e-l-e-c-t-r-o"
* I'm using MediaCabinet version 0.7.12b, built on October 15, 2012.

Thank you for your prompt response!

[hakko]

Two more question: saving the tag "e-l-e-c-t-r-o" works for me in Firefox/Chrome/Safari. Is this consistent in all browsers for you?

In your (subsonic settings)/jetty directory, do you have any directories except 0.7.12b? There has been issues sometimes with old JSPs floating around, causing weird interfering problems.

[pw22]

Hi hakko, there are no other directories except 0.7.12b. The behaviour is consistent across browsers (Chrome/Internet Explorer/Firefox). I was able to get "e-l-e-c-t-r-o" to tag by untagging all then tagging merely "e-l-e-c-t-r-o", but this didn't work for "rock".

Warm regards

[hakko]

In case you read the forum without logging in: PMs sent.

[pw22]

Dear hakko

Thank you very much for fixing the issue - and for all of your excellent work (past and future) on this fantastic program.

As a small token of my appreciation, I've made a donation of $50 AUD (slightly over 50 USD) to the United Nations Children's Fund (UNICEF).

Kind regards

pw22

[hakko]

This totally made my day, it really means a lot to me. Thanks for posting here and letting me know. I hope you know that you're making a difference, and that it can be an inspiration to others!

[jake-]

This totally made my day, it really means a lot to me. Thanks for posting here and letting me know. I hope you know that you're making a difference, and that it can be an inspiration to others!

If it helps to make you happy, I'd like to let you know that I donated 50EUR to "Doctors Without Borders" when we talked about it in august.

Thanks for all the time you spent on musiccabinet!

[hakko]

Oh, I had no idea! I promise, it makes me very happy. And very hopeful, too. Thanks.

[hakko]

hopefully resolved in 0.7.13. please note that adding tag corrections has one side effect for the tag cloud: if you add that genre A is misspelled and should actually be interpreted as genre B, then genre A will never appear in your tag cloud, while genre B always will.