[Bug] Problem with Players/Users

[vollbr0t]

Hi,

I experienced a very anoying problem: Sometimes when a user ("User 1") logs in and starts to play music, the player displayed in the lower frame (for example "Player 1") does not match the player used internally by musiccabinet (for example "Player 2"). This leads to problems when this Player 2 does not belong to User 1, but to another User (for example "User 2"). In this case the played music is scrobbled for the wrong player (User 2) and in the right frame the wrong user is displayed as "is playing now". When i delete the wrong player 2, and user 1 does a relogin, the correct player (1) is assigned and everything works perfect. I tried to delete all players to kind of reset the thing, but the problem reappears. The problem is not linked to a special user or player.

My assumption is that something got wrong with the internal connection between players. How do I reset this connections?
Maybe the fact that a lot of my users do use the same IP and the same Browser, and musiccabinet can not identify the users correctly. But i would think that the browser-cookie (login/pw) should be enough to identify a user clearly.

Please help!

thanks
Jan

[hakko]

This is Sindre's code again, so I don't know in detail how it works for players. I read up a bit and it wasn't super clear (to me at least) during what circumstances this would happen.

When you say that your users are using the same IP and browser, are they using the same machine? Or different machines but they're all using Firefox/Chrome or whatever? Why do they end up using the same IP, what's the setup? Is there any risk that one of your users has multiple player cookies on his/her machine? Do the playlists or song playback get mixed up with one user interfering with another user (adding to each other's playlists / hearing each other's songs), or is it only a problem with scrobbling/showing currently playing song?

As is always the case with Sindre's code, I'm a bit reluctant to change it quickly because I'm not sure about side-effects. There are no test cases or other way to tell that the code will actually keep working after an update. I'd rather just re-write big portions of it, but that's not exactly top priority right now either. I tried to reproduce the problem on my own machine using a few different users but no luck.

[Ultraviolet]

vollbr0t, are you referring to the same bug described here http://forum.subsonic.org/forum/viewtopic.php?f=2&t=9402&hilit=wrong+playing+user? If so, I can confirm it has been around for quite some time--I haven't experienced it in MC yet, but since it is built off of 4.6, I'm sure I will at some point. Supposedly Sindre fixed this in 4.7, but I've never tried that version so I can't verify that.

[vollbr0t]

The user do use different machines, but the same browser-version.

The IP is often identical because they all work in the same company, and they all work with one internet-connection.

I think it is not possible that any of those users have multiple cookies on his/her machine. We also tried deleting all cookies, that didn't help.

The playlists do get kind of mixed up... when the problem appears the lower frame displays the playlist from the wrong player (the one that does not belong to the user).

[vollbr0t]

Is there a plan on implementing the bugfix from sindre?

[hakko]

He considered it back in 2008. : ) viewtopic.php?t=1255. But honestly, I doubt it that such a bug report would get attention, it seems like adding new features has more priority than fixing bugs.

For me, the situation is similar to the whole playlist frame situation. I don't like all of Sindre's decisions and I think that many parts of the code would benefit from being re-designed completely. But it's a pretty big project and doing small updates (trying to tie player to user instead of IP/session or whatever it is now for example) seems like a risky project, removing features other people rely on and with a big potential of introducing new subtle errors. I don't have the time right now to do a makeover from scratch (working full time on some big projects) so I'll leave this open. I've also noticed that my player sometimes turns into jukebox mode. I'd wish Sindre would fix that too, but it doesn't seem very likely, so I rather wait until I have the time to write something I can take responsibility for.

[vollbr0t]

I didnt mean to reimplement the hole thing. Just to bug-fix the problem with wrong player-user associations, like sindre did from 4.6 to 4.7.

[hakko]

I found this in PlayerService.java. Might be the bugfix. http://i.imgur.com/h552P.png

[vollbr0t]

thank you hakko for your patience and time

[hakko]

Sindre's fix is included in 0.7.14, hopefully it helps!

[vollbr0t]

It seems like the problem is fixed! The bug didn't appear since the 0.7.14 update.

Thanks a lot!!!!!!!

[hakko]

\o/