Playlist Accessability

Alternative Android Client for Subsonic

Moderators: daneren2005, moderators

Playlist Accessability

Postby troycarpenter » Tue Feb 10, 2015 4:12 pm

At first I thought that all users could see everyone's private playlists on the system (but not access them). However, now that I've logged in with a normal user account, I see that a normal user only has access to their lists and any public lists. As the administrator, I see all the lists.

However, one annoyance is that, as administrator, even though I can see the lists, I'm not able to edit or access them from the client. There have been many times when I get into the car, my kids want me to play one of their playlists. Unfortunately, since playlists are created private by default, I can see the playlist but can't load it. I believe that if the administrator can see the playlists, then the admin account should have full access to the playlists regardless of the permissions. Otherwise, I have to use the web interface to make the list public before I can access.

Is that a change that can be done on the client, or does there need to be server change for that to happen?
Madsonic 6.2.9240
DSub on Samsung Note Edge
User avatar
troycarpenter
 
Posts: 41
Joined: Tue Apr 29, 2014 3:57 pm

Re: Playlist Accessability

Postby daneren2005 » Tue Feb 10, 2015 4:48 pm

I am pretty sure that is a Madsonic bug. Not being able to edit public playlists is by design on the server I believe, but any playlist that shows up should be viewable. If Madsonic doesn't want you to view the private playlists, they shouldn't be showing up in the list of playlists. If he does want them viewable, then he needs to fix it so they are viewable. On stock Subsonic you can view public non-owned playlists but you can't do anything to them. DSub has some controls on whether the options to add to or remove from a playlist show up, but none on whether you can view them since that is supposed to be handled at the server level.
Developer of DSub for Android
daneren2005
 
Posts: 1709
Joined: Fri Jul 06, 2012 7:52 pm

Re: Playlist Accessability

Postby troycarpenter » Tue Feb 10, 2015 5:58 pm

Let me define my terms because I started to confuse myself while writing the following. See=visible in the playlist list. Use=Able to view and play the songs on the list. Edit: Change any properties of the list...implies they can use it as well.

I do plan to bring this up on the Madsonic site. For non-administrators, it seems to be working as expected. Using Dsub, a non-admin user can see and edit their own playlists. They can also see and use public lists (not edit). A non-admin user cannot see other users' private lists.

As an admin user, in Dsub I can see every playlist, public or private from any user. I am presented all the options for all those lists (play the playlist, or even edit the properties). However, if I try to use or edit any private list, I get a authorization error.

I'm convinced now (although I was mostly convinced when I asked the original question) that this is a server issue. Since I don't have a Subsonic server, I can't confirm whether or not the same behavior happens with Subsonic vs. Madsonic.
Madsonic 6.2.9240
DSub on Samsung Note Edge
User avatar
troycarpenter
 
Posts: 41
Joined: Tue Apr 29, 2014 3:57 pm

Re: Playlist Accessability

Postby daneren2005 » Tue Feb 10, 2015 6:36 pm

troycarpenter wrote:Let me define my terms because I started to confuse myself while writing the following. See=visible in the playlist list. Use=Able to view and play the songs on the list. Edit: Change any properties of the list...implies they can use it as well.

I do plan to bring this up on the Madsonic site. For non-administrators, it seems to be working as expected. Using Dsub, a non-admin user can see and edit their own playlists. They can also see and use public lists (not edit). A non-admin user cannot see other users' private lists.

As an admin user, in Dsub I can see every playlist, public or private from any user. I am presented all the options for all those lists (play the playlist, or even edit the properties). However, if I try to use or edit any private list, I get a authorization error.

I'm convinced now (although I was mostly convinced when I asked the original question) that this is a server issue. Since I don't have a Subsonic server, I can't confirm whether or not the same behavior happens with Subsonic vs. Madsonic.

When talking purely about viewing, that is a Madsonic bug. If playlists for every user show up in your list of playlists, then you should be able to use them without an authorization error. When talking about editing, that sounds like it is probably a bug that DSub even shows the options in the first place. But I am going to wait to change anything with it until after we get feedback from Madsonic. It might be that he is going to change it so that admin users can edit private user's playlists, in which case there is nothing for me to change.
Developer of DSub for Android
daneren2005
 
Posts: 1709
Joined: Fri Jul 06, 2012 7:52 pm

Re: Playlist Accessability

Postby troycarpenter » Fri Feb 13, 2015 3:23 pm

Actually, based on the code I posted in the Madsonic forum, I looked in Subsonic repository and the same issue exists. It looks like this issue existed in Subsonic before Madsonic was forked. In short, the erroneous playlist behavior with respect to the admin user exists in both Subsonic and Madsonic.

http://sourceforge.net/p/subsonic/code/ ... rvice.java
Lines 140-152. Those routines should allow for the admin user.
Madsonic 6.2.9240
DSub on Samsung Note Edge
User avatar
troycarpenter
 
Posts: 41
Joined: Tue Apr 29, 2014 3:57 pm

Re: Playlist Accessability

Postby daneren2005 » Fri Feb 13, 2015 4:00 pm

It's not a bug in subsonic because subsonic doesn't show those playlists in the first place. That is the desired behavior for stock subsonic.

Sent from my Nexus 5 using Tapatalk
Developer of DSub for Android
daneren2005
 
Posts: 1709
Joined: Fri Jul 06, 2012 7:52 pm

Re: Playlist Accessability

Postby troycarpenter » Fri Feb 13, 2015 4:32 pm

Ah yes. After some more digging, I see where the getReadablePlaylistsForUser was modified in Madsonic to allow for the admin user to see all the playlists (in addition to allow for alternate sorting of the lists).
Madsonic 6.2.9240
DSub on Samsung Note Edge
User avatar
troycarpenter
 
Posts: 41
Joined: Tue Apr 29, 2014 3:57 pm


Return to DSub for Android

Who is online

Users browsing this forum: No registered users and 59 guests