Genres in "Edit Tags"

[Tekzel]

Hey Sindre, is there a file I can edit to remove a bunch of genres I will never ever use and add the ones that I do use that aren't there? Thanks for any help

[sindre_mehus]

Sorry, no. Those genres are the ones that are supported by ID3v1.

Sindre

[Tekzel]

Sorry, no. Those genres are the ones that are supported by ID3v1.

Sindre

I don't quite understand what you mean by this. I currently use MP3Tag outside of Subsonic to edit the tags to what I want, and it works fine. Are you saying that there some sort of "spec" that says that you have to use a certain list of tags? Which would be silly in my opinion, they are my MP3s why can't I set the genre to what I want, like I can in... ohhh everything else that can edit tags?

Also, is the list compiled into one of the java modules or something?

[sindre_mehus]

No, you can set the genre to anything you like, also in Subsonic, but the combo box is populated with the genres that were defined in ID3v1 and can't be modified without changing Java source code and recompiling.

Sindre

[Tekzel]

No, you can set the genre to anything you like, also in Subsonic, but the combo box is populated with the genres that were defined in ID3v1 and can't be modified without changing Java source code and recompiling.

Sindre

Ahh, ok thanks for the clarification. One last question on that subject, and I won't bother you again with it Is there any way to change the combo box from "limit to list" to a regular one, so I can type in what I want OR select from the box? On a podcast with 60 episodes changing it manually on each one sucks, would like to be able to use the SET function.

And, a bug I have run into. When changing multiple fields, usually most of them with the set ability (like 4 different tags) it will go through and say it did it but when I go back I find it has deleted most of the tags and they are blank. Even tags I didn't change, like the title. So, I usually do 1-2 tags at a time, then go back in and do 1-2 more to prevent that. I hope you understand what I am trying to say.

[teufelh]

For those who don't mind working a little, I've got a fix for this problem. (Temporary, working on better, need to brush up on Arrays.)

What I did was took out the part that for loops for every genre in the ID3 tag database pulled from the compiled Java file and hard coded each and every single Option tag.

Now what this does is increase the file size and the customization of the Genre selection box.

The part that looks like

Code: Select all

            <select name="genreAll" style="width:7em">
                <option value=""/>
                <c:forEach items="${model.allGenres}" var="genre">
                    <option ${genre eq model.defaultGenre ? "selected" : ""} value="${genre}">${genre}</option>
                </c:forEach>
            </select>

in the editTags.jsp file, needs to be replaced with something like this...

Code: Select all

<select name="genreAll" style="width:7em">
      <option value=""/>
         <option value="Genre">Genre</option>
      </select>


Then simply add as many Genres as you like.

For me though, I liked all the Genres that were there, so I simply loaded the editTags.jsp and viewed the compiled HTML source, through a web browser. I copied and pasted the generated <option> tags and pasted them in between the <select> tags. Now I have ALL the genres and I can freely add my own.

(As I said, I'm going to brush up on arrays so it'll just be 1 line that you have to change and not adding 40 or 50 lines to this file.

[hylianux]

Actually, I kinda wanted the ability to just manually enter whatever I wanted, and have it populate down the list. The combo box is nice for common genres, and I love how it'll populate down the page... but if I want to put my own genre in that isn't in the list, I have to add it to EVERY SINGLE TRACK in the list manually. I feel this limits functionality.

This aggravated me so much I decided to add my own text box in there where I could manually enter whatever I wanted, and a link next to it that would populate it all the way down.

I added 2 pieces to the editTags.jsp (on Debian, this is found in the /var/subsonic/jetty/3434/webapp/WEB-INF/jsp/editTags.jsp)

one is a javascript function:

Code: Select all

    function setGenreTxt(){
        var genre = dwr.util.getValue("genreAllTxt");
        for (i=0; i<fileCount; i++) {
            dwr.util.setValue("genre" + i, genre);
        }
    }


The other goes right where the select box is:

Code: Select all

<input type="text" name="genreAllTxt" id="genreAllTxt" style="width:7em;" /> <a href="javascript:setGenreTxt()"
   id="gatSubmit" name="gatSubmit"><fmt:message key="edittags.set"/></a><br>
<select name="genreAll" style="width:7em">
    <option value=""/>
    <c:forEach items="${model.allGenres}" var="genre">
        <option ${genre eq model.defaultGenre ? "selected" : ""} value="${genre}">${genre}</option>
    </c:forEach>
</select>


The end result stretches the columns vertically, which some might think is a little ugly... but damned if it isn't functional. If I've got an album full of like 99 songs or something, I don't want to painstakingly go through each and every genre text box and enter the genre, any more than I want to download all the songs from my server, fix with a tagger program, then upload 'em all back.

Here's a screenshot of the end result:



What do you all think?