Using Android App Causes subsonic-service.exe to 100% CPU

[tguless]

I should also add that the server requires a restart after replacing these files.

[blinkfink182]

Again, you are the man. I'll download those tonight and give it a shot. I'll let you know tomorrow how it goes.

Thanks again. This is why open source is the way to be.

[blinkfink182]

The new files appear to have made it worse. Now it is constantly using as much CPU as it can from startup and there must be a memory leak somewhere as now the memory usage in over 400MB, when it i usually well under 100MB. In the log in the webapp, I see entries like this, over and over and over again. Any ideas?

Code: Select all

[7/29/10 7:38:56 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:39:08 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:39:20 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:39:35 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:39:40 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:39:52 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:40:05 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:40:17 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:40:29 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:40:29 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:40:48 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:40:50 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:41:02 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:41:02 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:41:04 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:41:14 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:41:26 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:41:39 AM CDT]   INFO   RESTController   Before searchService
[7/29/10 7:41:53 AM CDT]   INFO   RESTController   After searchService
[7/29/10 7:41:59 AM CDT]   INFO   RESTController   Before searchService

[/code]

[tguless]

Ok just noticed server this morning was again unresponsive.

The call has been sped up, but I don't think it's enough:

[2010-07-29 08:35:32,427] INFO RESTController - Before searchService
[2010-07-29 08:35:32,428] INFO SearchService - begin getIndex()
[2010-07-29 08:35:32,428] INFO SearchService - end getIndex()
[2010-07-29 08:35:32,428] INFO SearchService - begin iterationLoop()
[2010-07-29 08:35:39,393] INFO SearchService - end iterationLoop()
[2010-07-29 08:35:48,202] INFO RESTController - After searchService


Now only takes 16 seconds to complete, but android makes a call to this script every 12. So it still bogs down the server. I wish there was a way to change the time out period on the android app.

192.168.35.1 - - [26/Jul/2010:11:36:15 -0400] "GET /subsonic/rest/getRandomSongs.view?u=admin&p=enc:686169673234&v=1.2.0&c=android&size=100 HTTP/1.1" 502 571 "-" "-"

192.168.35.1 - - [26/Jul/2010:11:36:28 -0400] "GET /subsonic/rest/getRandomSongs.view?u=admin&p=enc:686169673234&v=1.2.0&c=android&size=100 HTTP/1.1" 502 571 "-" "-"

192.168.35.1 - - [26/Jul/2010:11:36:40 -0400] "GET /subsonic/rest/getRandomSongs.view?u=admin&p=enc:686169673234&v=1.2.0&c=android&size=100 HTTP/1.1" 502 571 "-" "-"

[tguless]

Ok also changed line 496

From:
size = Math.max(0, Math.min(size, 500));

To:
size = Math.max(0, Math.min(size, 25));

This sets the upper limit of the getRandomSongs call to 25 instead of 500.

The call from the android phones requests 100 songs. Now this will only return 25 songs.

I've updated the files, please grab a fresh copy

The call is much faster now:

[2010-07-29 09:02:29,507] INFO RESTController - Before searchService
[2010-07-29 09:02:35,336] INFO RESTController - After searchService

Completes in 6 seconds. Should not bog down the server, unless there are alot of these coming in.

Ted

[tguless]

Also set an upper limit of 5 for the random albums query. So now the random function on android works for me.

The http call looks like this:

/subsonic/rest/getAlbumList.view?u=admin&p=enc:686169673234&v=1.2.0&c=android&type=random&size=20&offset=0

The lines I changed are around line 463 in the file RESTController.java

} else {
size = Math.max(0, Math.min(size, 5));
albums = homeController.getRandom(size);
}

Again I've posted updates, and again please grab fresh copies of the 3 files from my server and test.

Thanks,
Ted

[blinkfink182]

THERE IT IS!

Nailed it man, all is good now. Thanks again, so so so much.

Everyone with this issue, grab the files linked in the last post on page one. Resolves the issue.

[tguless]

Just curious, do you have 3 android clients configured to connect to your server?

According to those last logs, your server was getting hammered with repeating random song list requests. I think the Android client needs cleanup as well. If I have time I'll dig into that code as well. But I think my volunteer time is better spent in addressing the server performance issues.

This project has so much potential. It is very well written, and I love how self contained it is. I can learn alot from this.

I'm a huge fan.

[Gabriel1964]

Thank you, was totally flumexed as to why my whs was running at 100% utilisation of the cpu. This fixed it.

much appreciated

[blinkfink182]

@tgluess:

Nope, just my one phone, no other Android clients.

[tguless]

Redownload the same 3 files from the same URL. The new fix will actually fix the file browser so you can browse your folders. With my large collection it was timing out. I removed the coverart data population calls, and it is actually functional now. I just don't see coverarts in that section, which is fine by me.

[sindre_mehus]

Hi all,

Thanks for bringing this to my attention. I will optimize this code in the next Subsonic release.

Thanks again,
Sindre

[lpadron]

Redownload the same 3 files from the same URL. The new fix will actually fix the file browser so you can browse your folders. With my large collection it was timing out. I removed the coverart data population calls, and it is actually functional now. I just don't see coverarts in that section, which is fine by me.

tguless, Thanks!!!!

I suddenly started getting 100% util on SS the past few days (after 4 months use) on my XP PC. Downloaded your class files and they did the trick!!! Thanks for the edits. Proves the value OPEN SOURCE!!!

[tguless]

But looking at the changelog history:

http://www.subsonic.org/pages/changelog.jsp

Under the heading Subsonic 4.1.beta1 - Aug 21, 2010

There's an item titled:
Performance: Faster coverart lookup.

I am still running an old version in fear of having slow performance again, also the Ubuntu repository version seems to still be 4.0.1

apt-cache show subsonic

Package: subsonic
Status: install ok installed
Priority: optional
Section: Multimedia
Maintainer: Sindre Mehus <sindre@activeobjects.no>
Architecture: all
Version: 4.0.1
Recommends: lame, flac, faad, vorbis-tools, ffmpeg
Conffiles:
/etc/default/subsonic d539125930bb47f8075b4c35e429b214
Description: A web-based music streamer, jukebox and Podcast receiver
Subsonic is a web-based music streamer, jukebox and Podcast receiver,
providing access to your music collection wherever you are. Use it
to share your music with friends, or to listen to your music while away
from home.
.
A Subsonic client for Android phones is also available.
.
Java 1.6 or higher is required to run Subsonic.
.
Subsonic can be found at http://subsonic.org