showNowPlaying in top.jsp

[Yokhannan]

Hello,

I would like to relocate the "nowplaying" feature from "right.jsp" to "top.jsp"

I have copied the required javascript files and all of the code (from <c:if test="${model.showNowPlaying}"> to the closing c) into top.jsp.

But it does not seem to be working.

Would love some help. I am a donating user.

Thanks.

[supra92]

Interesting request/desire. One thing I'm having difficulty visualising is how exactly you'll be able to show the Now Playing information if, say, five or six different users are all playing at the same time. The right pane goes the entire height of the screen, so there's room for a lot, and it can add a vertical scrollbar if necessary.

But the top pane? On my screen (1920x1200) the logo, top icons (home, playing, settings, status, etc.), and the Logout link take up more than half of the width of the frame. On a 1280x1024 resolution it would take up the vast majority of the screen real estate of top.jsp.

Where do you visualise the list of Now Playing icons going? Are you wanting a scrollbar on that thin top.jsp, and if so are you wanting a horizontal one or a vertical one? If you're picturing horizontal scrolling, you might have to modify the JSP code even more, so that each additional user's Now Playing information goes to the right of each other, instead of beneath.

Somehow, I'd think top.jsp would get awfully cramped up there even with just 2 or 3 users playing music, since each Now Playing entry has username, artist name, song title, album art, and the lyrics link...

Supra92

[Yokhannan]

Hello,

I have made major cosmetic changes to the top bar.

As for multiple people - not an issue, I am the only person using it. And, even if I do happen to have it playing on both my computer and my mobile device, it is easy enough to only display a single user.

The issue is that if I place "<c:if test="${model.showNowPlaying}">" than it does not work at all. And, if I remove that, I get serious .js error alerts that I cannot seem to resolve, when the player is first opened in the browser - because there is nothing playing.

[supra92]

Makes a lot more sense if you're the only user of SS, agreed. Being the only user, you'd also have no need for the Chat feature either, which would allow you to nix the right frame entirely to make a lot more space for the main area with the album art (and the left artist pane too, if so inclined).

I've done some mods as well, which I have to keep track of each time I upgrade to a new version of SS -- usually I can just copy over my top.jsp or index.jsp or etc. that has my customisations in them, but at some point Sindre may make his own changes in those where I won't want to overwrite. I'm starting to manually write out the various code changes I do to each JSP file so I can manually edit the new files from each subsequent new version, so I'm not accidentally overwriting new features with an old JSP file. Kind of a pain, but necessary

I'm not sure what to say about the "<c:if test="${model.showNowPlaying}" part, though... I do have a spare Linux server here that has SS on it (not in use), so I may play around with this one to see if I can do what you're describing.

Supra92

[Yokhannan]

Well so far today I have been able to figure out how to not get the bazillion js alert errors to come up when I first load the page. Only thing it is not doing is to be blank... it keeps displaying the last song that was played. On the hunt now for the function that controls that.