Ultraviolet wrote:Love what I'm seeing so far. Great work. A few thoughts in a Win 7 64bit system with your .war in the shared dropbox on 4.6.beta1.
Bug:
-Can't get anything other than the main frame to render in most recent version of FF. Things work great in Chrome though.
Other thoughts:
-I like what you're doing with the Random Playlist functionality. What about moving it to a more logical location like the advanced portion of trickydick's player mod? I've always thought Sindre had that in a strange spot. Almost none of my users even know it exists.
-It would be great if the playlist frame was resizable.
-I absolutely love the drag and drop playlist functionality. Can you get rid of the Up/Down arrows now on the tracks in the playlist?
-A piece of functionality that was in trickydick's Outlook themes was a "previous"/"next" or "forward"/"back" (can't remember) functionality where if you had 100 U2 albums and you selected one to view the tracks in the main frame, you could move alphabetically forward and backward without having to return to the jquery accordian. I don't see that implemented in currently, but I loved the convenience of that.
Thanks for the awesome work--I'm loving the changes (especially drag and drop playlists!).
Thanks for the feedback. I've narrowed the bug down to the Google Webfonts not loading nicely in Firefox, so until I can figure it out I may disable the feature for firefox users. In the meantime, if you are reliant on Firefox for your browsing you can open the /WEB-INF/jsp/head.jsp file and remove the tag
- Code: Select all
<script type="text/javascript" src="<c:url value='/script/webfont.js'/>"></script>
This should let everything load properly in Firefox.
I have definitely considered moving the random playlist generator to a better location. It's under my todo's for random playlist generator tweaks
I'm planning to completely remove the entire 'frames' system and re-implement it as a modular 'window' system to allow better control of window size and layout.
I've left the up/down buttons temporarily for 'legacy users' until the new drag/drop functionality is better implemented. Eventually it will be an option the user can choose to enable drag/drop or up/down playlist sorting (or both).
I'm not sure what you mean about the last point, but that feature should (still) be there... IE, if i have five beastie boys albums, and I click one of them, it will show the previous or next alphabetical album for that artist... Is this what you're referring to?
BKKKPewsey wrote:As I finally found my war file which was hiding(new glasses reqd.) in program files/subsonic I thought I would give this a try. So I deleted my jetty folder, replaced the war file with new one and re-started SS.
This unpacked the war file successfully but instead of putting the files in jetty/xxxx/webapp they appeared in jetty/webapp.
Thinking this was probably not a good idea I re-installed 4.6beta by renaming my war files again, checked all was back working and then unzipped the war file and replaced webapp with the new files. In anticipation I fired up chrome and got :-
Just the backgrounds and the frame borders with the rather unhelpful message
It is probably me doing something obviously stupid but what I cannot guess what
Windows Server 2003
Believe it or not, the error actually makes perfect sense (to me). The "cannot call message 'not' of null" is basically saying there was a failure of the jquery function call '.not()' trying to call something which doesn't exist (it's null\hasn't loaded yet)...
I will narrow the issue down (it's only called once) and figure out what the call is referencing and why it's having some problems.
If you'd like to try some troubleshooting for me, try opening the /WEB-INF/jsp/playlist.jsp file and scroll to the end. Then modify the 'jQueryLoad.wait' so it looks like this:
- Code: Select all
<script type="text/javascript">
jQueryLoad.wait(function() {
jQueryUILoad.wait(function() {
$(init)
});
});
</script>
I'm thinking the problem was due to the fact the 'init' was being called as soon as jQuery was loaded instead of waiting for jQueryUI to load too.
Since the Drag/Drop functionality is a part of jQuery UI, we need to wait for it to load otherwise the playlistCallback function will throw errors.
Even though the .not() function is part of jQuery (not jQueryUI), I'm hoping this might fix it by nature of randomness.
Anyways, If you're having any trouble getting your Subsonic back to a working state let me know and I'll try to help.
Also I'm not sure, but it might be the default functionality of the Windows version to unzip the war right to the jetty/webapp folder and skip the build number (jetty/####) folder. I will have to confirm this.
I will post an updated war once I fix these two issues.
