Subsonic Web UI Cleanup\Overhaul

Third-party modifications and add-ons, Apps and Clients

Moderator: moderators

Re: Subsonic Web UI Cleanup\Overhaul

Postby tbastard » Sat Nov 26, 2011 8:53 pm

Thanks for the updated war file, it's looking better and better :D

I still have a problem adding tracks to the playlist, the button to add the song now does something when I click it, but the song is still not added to the playlist.

I also now have a problem in that I can not control the volume in jukebox mode anymore. I can only mute.

Thanks again for the great mod!

c
tbastard
 
Posts: 3
Joined: Wed Nov 23, 2011 7:01 pm

Re: Subsonic Web UI Cleanup\Overhaul

Postby califrag » Sat Nov 26, 2011 9:38 pm

tbastard wrote:Thanks for the updated war file, it's looking better and better :D

I still have a problem adding tracks to the playlist, the button to add the song now does something when I click it, but the song is still not added to the playlist.

I also now have a problem in that I can not control the volume in jukebox mode anymore. I can only mute.

Thanks again for the great mod!

c


hm.. Which 'button to add' are you using? When I'm viewing an artist and it displays the albums for the artist, I can click the little "[+]" icon and it will add the entire album to the playlist. Same thing if I am viewing an album, I can click the '[+]' button and it will add whichever song I clicked to the playlist. Is this the button you are referring to?

Or are you talking about on the playlist window, if you have some songs selected then click the 'Advanced' and '+' button, then choose a playlist and click 'Add'?

For the volume slider I probably didn't hook the gain controls correctly so let me check that out and try to fix it. Or... are you not even getting a volume slider at all?
califrag
 
Posts: 72
Joined: Mon Sep 26, 2011 3:43 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby Drefsab » Sun Nov 27, 2011 9:49 am

califrag wrote:Would you mind posting up your SS setup here ? what OS do you use and what web browsers? Do you have multiple users or are you the primary user? any other info you think might be good for reference. Just a little extra feedback to help during debugging and identifying possible issues, thanks in advance :)


Sure

My server is only used by myself for now (until I have a way to segregate content between users subsonic just doesn't fit my needs for multi-users).

Its all running on a ubuntu 11.10 server (running as a VM on my esxi server).

The primary webserver is nginx + varnish, which I was using to cache and proxy all web traffic. This caching is what was causing problems with jetty, I've take it out of the loop for now and installing SS on its own port and that worked a treat, I will have a play in work this week to intergrate it all. I never really needed speed its a stupidly powerful server for what I use it for but I like things to be efficient :)

So far im using google chrome v15 and firefox v8.

I put your updated war on and the UI improvement can certainly be seen :)

Though I did hit another bug, in chrome when I try to play any music I get "Cannot read property 'length' of null" errors, if I click it from the middle pane, if I click the play list items it just doesnt play, video is fine. Firefox doesn't play music either but doesn't give an error message.
Drefsab
 
Posts: 47
Joined: Sat May 07, 2011 9:44 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby pemholder » Sun Nov 27, 2011 11:20 am

Drefsab wrote:Though I did hit another bug, in chrome when I try to play any music I get "Cannot read property 'length' of null" errors, if I click it from the middle pane, if I click the play list items it just doesnt play, video is fine. Firefox doesn't play music either but doesn't give an error message.

I updated to the newest WAR-File today too.
I use Windows XP Pro.

When I klick on play or + in Firefox I only get "slider is null", in Chrome I get "Cannot read property 'length' of null", IE8 works fine.
pemholder
 
Posts: 97
Joined: Wed Dec 09, 2009 1:28 pm

Re: Subsonic Web UI Cleanup\Overhaul

Postby pemholder » Sun Nov 27, 2011 11:42 am

I think I found another bug:
When I use the serach-function and it exceed a certain amount of results, I don't get all search results. Instead of this there is blue delimiter-lines of odd characters (see attachment)
search_error.jpg
pemholder
 
Posts: 97
Joined: Wed Dec 09, 2009 1:28 pm

Re: Subsonic Web UI Cleanup\Overhaul

Postby Drefsab » Sun Nov 27, 2011 3:11 pm

Yup I can confirm that using IE9 the errors no longer come up and music plays.
Drefsab
 
Posts: 47
Joined: Sat May 07, 2011 9:44 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby califrag » Sun Nov 27, 2011 6:55 pm

Drefsab wrote:
califrag wrote:Would you mind posting up your SS setup here ? what OS do you use and what web browsers? Do you have multiple users or are you the primary user? any other info you think might be good for reference. Just a little extra feedback to help during debugging and identifying possible issues, thanks in advance :)


Sure

My server is only used by myself for now (until I have a way to segregate content between users subsonic just doesn't fit my needs for multi-users).

Its all running on a ubuntu 11.10 server (running as a VM on my esxi server).

The primary webserver is nginx + varnish, which I was using to cache and proxy all web traffic. This caching is what was causing problems with jetty, I've take it out of the loop for now and installing SS on its own port and that worked a treat, I will have a play in work this week to intergrate it all. I never really needed speed its a stupidly powerful server for what I use it for but I like things to be efficient :)

So far im using google chrome v15 and firefox v8.

I put your updated war on and the UI improvement can certainly be seen :)

Though I did hit another bug, in chrome when I try to play any music I get "Cannot read property 'length' of null" errors, if I click it from the middle pane, if I click the play list items it just doesnt play, video is fine. Firefox doesn't play music either but doesn't give an error message.


pemholder wrote:
Drefsab wrote:Though I did hit another bug, in chrome when I try to play any music I get "Cannot read property 'length' of null" errors, if I click it from the middle pane, if I click the play list items it just doesnt play, video is fine. Firefox doesn't play music either but doesn't give an error message.

I updated to the newest WAR-File today too.
I use Windows XP Pro.

When I klick on play or + in Firefox I only get "slider is null", in Chrome I get "Cannot read property 'length' of null", IE8 works fine.



Thank you for the info. Not sure what is going on with the 'not playing' bug, I am still investigating this. I can't seem to reproduce the issue on my end yet, whenever I click the "+' from the middle pane, or click the playlist item it plays normally.

I will post an updated .war as soon as I've got it figured out though.

pemholder wrote:I think I found another bug:
When I use the serach-function and it exceed a certain amount of results, I don't get all search results. Instead of this there is blue delimiter-lines of odd characters (see attachment)
search_error.jpg


Agh! Ooops.. I forgot to clean up the search page...It will be cleaned up in the next .war update. Sorry!!!


Drefsab wrote:Yup I can confirm that using IE9 the errors no longer come up and music plays.


Hmm this is interesting... I'm wondering if Chrome or Firefox are having a cache issue?

I will mess with it some more today and see if I can get it worked out.
califrag
 
Posts: 72
Joined: Mon Sep 26, 2011 3:43 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby Drefsab » Sun Nov 27, 2011 10:24 pm

I did try clearing the cache just now on firefox, it did resolve the issue kept giving slider is null error's plus I was getting odd issues bring up the tracks in the middle pane of the album, I select the album once I get 3 tracks, a second time I get 12 the 3rd time I got 22 (the full amount). I also dont get the playlist down the bottom on firefox though I do on chrome. I tried chrome and that was the same as before.

If it would help id be happy to create an account on my server for you, any assistance I can give :)
Drefsab
 
Posts: 47
Joined: Sat May 07, 2011 9:44 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby califrag » Sun Nov 27, 2011 10:44 pm

Drefsab wrote:I did try clearing the cache just now on firefox, it did resolve the issue kept giving slider is null error's plus I was getting odd issues bring up the tracks in the middle pane of the album, I select the album once I get 3 tracks, a second time I get 12 the 3rd time I got 22 (the full amount). I also dont get the playlist down the bottom on firefox though I do on chrome. I tried chrome and that was the same as before.

If it would help id be happy to create an account on my server for you, any assistance I can give :)


Sure if you'd like to PM me the login details I will see if I can figure out what's going on.

So just to confirm, after clearing the cache the 'slider is null' error is gone.

Are you still getting the odd 'track count' issues where it doesn't fully load the tracklist or is that also resolved?

When you say you don't get the playlist, does the entire 'playlist frame' not load (no player, controls, menu, etc), or is it JUST the playlist (you can still see the player, controls, menu, just no tracks)? Is it showing 'Playlist is empty' or nothing at all?
califrag
 
Posts: 72
Joined: Mon Sep 26, 2011 3:43 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby Drefsab » Sun Nov 27, 2011 11:17 pm

ok PM is sent,

I wasnt getting an error on firefox before I cleared the cache after I was. Music wasnt playing either way. The playlist worked this time around, its weird and hard to reproduce I guess, the odd listing of tracks though seams to be happening more consistantly.

http://vm1.drefsab.co.uk/1.png tracks not all showing
http://vm1.drefsab.co.uk/2.png slider error when I try to play a track from that list
http://vm1.drefsab.co.uk/3.png reloaded the same album and now showing all tracks

This is all with firefox 8, IE 9 has been smooth not seeing any issues on that. I haven't had chance to test chrome properly as its not on the pc im using at work.
Drefsab
 
Posts: 47
Joined: Sat May 07, 2011 9:44 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby califrag » Sun Nov 27, 2011 11:46 pm

Drefsab wrote:ok PM is sent,

I wasnt getting an error on firefox before I cleared the cache after I was. Music wasnt playing either way. The playlist worked this time around, its weird and hard to reproduce I guess, the odd listing of tracks though seams to be happening more consistantly.

http://vm1.drefsab.co.uk/1.png tracks not all showing
http://vm1.drefsab.co.uk/2.png slider error when I try to play a track from that list
http://vm1.drefsab.co.uk/3.png reloaded the same album and now showing all tracks

This is all with firefox 8, IE 9 has been smooth not seeing any issues on that. I haven't had chance to test chrome properly as its not on the pc im using at work.



Okay, I can tell just from the screenshots that jQuery UI isn't loading/executing properly... That's why the buttons look like normal buttons and the slider isn't being generated.

I just logged in and confirmed that it seems jQuery UI isn't caching and loading right.

I may need to play around with the cache filters to see if I can resolve it, but I am working on some of the reliability issues right now hoping to fix some of the other bugs I've created :P

I will try to post up an updated .war tonight. I'm currently testing a newer cleaned up version.
califrag
 
Posts: 72
Joined: Mon Sep 26, 2011 3:43 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby Drefsab » Sun Nov 27, 2011 11:54 pm

no problem :) well I will install it when its done, there's no rush or anything mate you clearly are working hard so dont want to add pressure just wanting to help bug hunt etc :)
Drefsab
 
Posts: 47
Joined: Sat May 07, 2011 9:44 am

Re: Subsonic Web UI Cleanup\Overhaul

Postby pemholder » Wed Nov 30, 2011 9:08 am

pemholder wrote:When I klick on play or + in Firefox I only get "slider is null", in Chrome I get "Cannot read property 'length' of null", IE8 works fine.

I noticed today that when I enable private mode in Firefox 8.0, there ist no error message.
pemholder
 
Posts: 97
Joined: Wed Dec 09, 2009 1:28 pm

Re: Subsonic Web UI Cleanup\Overhaul

Postby pemholder » Wed Nov 30, 2011 9:21 am

califrag wrote:Again I just want to re-iterate that this mod was never intended to be put into any production environment.

I started modding this just to get some of the requested features 'written down' (in code) so that Sindre could incorporate them into the official branch.
Unfortunately, I think I've changed so much that Sindre doesn't wanna touch any of my code (I don't blame him).


I understand this and therefore I installed your mod only besides my productive installation locally.

But there are at least 2 items, that I would like to see in my productive installation and I would like to mod this myself:
Accordeon
Artists simmilar to

Is is possible to add these items easily for me or do they depend on special code, that is not in the official branch?
If possible, what and where do I have to change the official branch.
pemholder
 
Posts: 97
Joined: Wed Dec 09, 2009 1:28 pm

Re: Subsonic Web UI Cleanup\Overhaul

Postby MaxSan » Wed Dec 07, 2011 10:27 pm

Hey - tried i installing this it seemed to not work. I then deleted it n restored my jetty + war to the originals and it hasnt went back. the interface looks odd lol. Missing proper layout n settings and such.

Any ideas?
MaxSan
 
Posts: 6
Joined: Thu Dec 01, 2011 11:32 am

PreviousNext

Return to Mods, Apps and Clients

Who is online

Users browsing this forum: No registered users and 3 guests