Subsonic For ICS Android 4.0

General discussions.

Moderator: moderators

Re: Subsonic For ICS Android 4.0

Postby ttabbal » Sat May 19, 2012 2:56 pm

Here's a logging version for the basic key info. If you have adb, you can use "adb logcat > log.txt" then use the keys. Crtl-C to stop it. If not, use an app called "catlog" in the market. You can filter on "AVRCP" to see just the events we care about. The app can send the logs out via email or save to files. You can post it here to email to me directly at "travis@tabbal.net". If you can, It would be nice if you can annotate the file with comments showing me what button you pushed, then the log statements it put out. Or feel free to do multipule posts. I know it's a little more time consuming, but it will help speed things up if I'm not guessing what events are produced from which button.

I double checked my headset with this build, everything works as I would expect. If it doesn't with yours, we need to find out why and get it fixed.
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Re: Subsonic For ICS Android 4.0

Postby Xious » Sat May 19, 2012 3:10 pm

Maes wrote:
ttabbal wrote:Well... I managed to apply that patch... It loads up OK. Anyone want to test it with hardware? I don't think I have anything that can do it.


I have been using the android subsonic app on ICS in combination with a scala rider g9 headset for my motorcycle helmet. The 05-06-2012 build has very bad compatibility with the AVRCP protocol. The headset is able to stop the music on the app, but it can not make it play again. This is a problem because it means I have to stop on the side of the road to press the play button on my phone.
I have tested the setting with the app provided in the quoted post above and it works a little bit better but it's not perfect: The app is able to play music on the bluetooth play command and can even skip and rewind to next and previous songs, but can not make the music stop. This means that when I get a call on my headset the music will keep playing through it, it's very annoying.

Could anyone be so kind to release a version with the correct AVRCP code? It would be a tremendous help for me so I can happily listen to music on my bike :)

I have the same issue with being able to pause but having trouble getting it to play again on my Galaxy Nexus. I have found that if I just turn on the screen, I can get it to play again. But if the screen remains off, it will not respond to the headset.

X
Xious
 
Posts: 2
Joined: Sun Mar 11, 2012 3:42 pm

Re: Re: Subsonic For ICS Android 4.0

Postby ttabbal » Sat May 19, 2012 3:17 pm

Xious,

Please use the latest build and send me the log.. Which rom and kernel? I which gnex?
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Subsonic For ICS Android 4.0

Postby Maes » Sat May 19, 2012 5:05 pm

ttabbal wrote:Here's a logging version for the basic key info. If you have adb, you can use "adb logcat > log.txt" then use the keys. Crtl-C to stop it. If not, use an app called "catlog" in the market. You can filter on "AVRCP" to see just the events we care about. The app can send the logs out via email or save to files. You can post it here to email to me directly at "travis@tabbal.net". If you can, It would be nice if you can annotate the file with comments showing me what button you pushed, then the log statements it put out. Or feel free to do multipule posts. I know it's a little more time consuming, but it will help speed things up if I'm not guessing what events are produced from which button.

I double checked my headset with this build, everything works as I would expect. If it doesn't with yours, we need to find out why and get it fixed.


I just got home and tried out the build. I couldn't get logcat to work it just keeps showing the loading icon endlessly. I did however fiddle around with the headset buttons and it works now. I was able to start the music with my headset and stop it, as well as skipping to the next / previous song. I kept testing it by turning it off and on and off and on again and a couple of times I was suddenly no longer able to start the music again unless I turned my phone on and unlocked it. Also on a few occasions when I stopped the music and started it again it would start on the next song instead of continuing where it left of. Although I realize that's not much information to go by I wouldn't ask you to improve any more because it seems to work 99.99% of the time. Bravo. And thanks for helping me get my headset to work properly! Now I can finally enjoy my own music on my motorcycle without having to get off to change the tune!
Maes
 
Posts: 16
Joined: Sat May 19, 2012 7:37 am

Re: Subsonic For ICS Android 4.0

Postby ttabbal » Sun May 20, 2012 3:21 am

That's great news! Enjoy the tunes and ride safe.. :-)
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Subsonic For ICS Android 4.0

Postby oshogg » Tue May 22, 2012 8:48 am

I still have one problem with the latest build. When the bluetooth disconnects, I would like Subsonic to pause play automatically. And, when the bluetooth connects, Subsonic should automatically resume paused play. Is this expected to work in this build?

Note that my Bluetooh device doesn't send play/pause buttons on its own upon connection/disconnection (unfortunately).

Osho
oshogg
 
Posts: 33
Joined: Thu Nov 12, 2009 3:43 pm

Re: Subsonic For ICS Android 4.0

Postby ttabbal » Tue May 22, 2012 2:24 pm

oshogg wrote:I still have one problem with the latest build. When the bluetooth disconnects, I would like Subsonic to pause play automatically. And, when the bluetooth connects, Subsonic should automatically resume paused play. Is this expected to work in this build?

Note that my Bluetooh device doesn't send play/pause buttons on its own upon connection/disconnection (unfortunately).

Osho



No, it isn't set up for that. I use more than Subsonic with my headset so I wouldn't want that anyway. It could be made optional, but I don't know when I'll have time to look into it.
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Subsonic For ICS Android 4.0

Postby oshogg » Tue May 22, 2012 11:59 pm

ttabbal wrote:
oshogg wrote:I still have one problem with the latest build. When the bluetooth disconnects, I would like Subsonic to pause play automatically. And, when the bluetooth connects, Subsonic should automatically resume paused play. Is this expected to work in this build?

Note that my Bluetooh device doesn't send play/pause buttons on its own upon connection/disconnection (unfortunately).

Osho



No, it isn't set up for that. I use more than Subsonic with my headset so I wouldn't want that anyway. It could be made optional, but I don't know when I'll have time to look into it.


Yes, it would be great to have an option for this. I use Subsonic exclusively on my phone for all my media. So, it would be awesome to be able to just have Subsonic play automatically when I start my car (which connects with Car's built-in bluetooth) or when I turn on the bluetooth headset.

Thanks,
Osho
oshogg
 
Posts: 33
Joined: Thu Nov 12, 2009 3:43 pm

Re: Subsonic For ICS Android 4.0

Postby archrival » Wed May 23, 2012 10:59 pm

Hey all. I have seen a few people have downloaded my builds from https://github.com/archrival/Subsonic-Android. I haven't seen any feedback either positive or negative and I'm curious if anyone has had a chance to use it enough to be able to provide any feedback?

I've noticed that multiple developers are maintaining their own branches, hopefully we can get some or all of these changes merged back into the main code. I know Sindre has said the Android client comes after the server so hopefully time has been saved.

Today I posted a change for ICS based devices without a menu button. I noticed some of you have mentioned the new ICS build doesn't allow you to go to Settings. I removed the "more" button and added a Help and Settings button, it saves a step and more closely follows the Android guidelines. Give the build posted on 5/23 a try and see how it works for you. I appreciate any feedback.
archrival
 
Posts: 173
Joined: Wed May 26, 2010 6:02 am

Re: Subsonic For ICS Android 4.0

Postby oshogg » Thu May 24, 2012 12:07 am

archrival wrote:I've noticed that multiple developers are maintaining their own branches, hopefully we can get some or all of these changes merged back into the main code. I know Sindre has said the Android client comes after the server so hopefully time has been saved.


Could someone quickly summarize what branches are there now and what they contain/does not contain. I have downloaded and tested one of the .apks attached to a post above but I do not recollect exactly which one. Knowing this information would help me/others make an educated decision as to which .apk to download and test?

Of course, it would be best if all of these could be integrated in one branch or the main branch.

Thanks,
Osho
oshogg
 
Posts: 33
Joined: Thu Nov 12, 2009 3:43 pm

Re: Subsonic For ICS Android 4.0

Postby archrival » Thu May 24, 2012 2:33 am

I would love for anyone to take all or none of my changes. It would be best if there were one common code base for now until the official code is updated, I'm not sure which code base should be the one. I tried to incorporate some of the other changes posted here, but some were no longer applicable and others caused problems.

My personal fork on github contains the following changes:

    1. Buffer length in settings
    2. Network timeout in settings
    3. Modified the play button to a pause button in the notification widget
    4. Changed the server selection drop down from a compass to a drop down arrow
    5. Removed the options menu button and replaced with Help and Settings link, pre-ICS devices with a hardware menu button can still access the menu
archrival
 
Posts: 173
Joined: Wed May 26, 2010 6:02 am

Re: Subsonic For ICS Android 4.0

Postby ttabbal » Thu May 24, 2012 3:09 am

I agree that one CodeBase is good. I sent a pull request to the first one. But they never responded. If you'd like I could integrate all the changes and post a single repository. I just need to know what to add. A pull request is the easiest way. But I can merge from your repos as well if you post them here.

https://github.com/travistabbal/Subsonic-Android
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Subsonic For ICS Android 4.0

Postby oshogg » Thu May 24, 2012 5:09 am

ttabbal wrote:I agree that one CodeBase is good. I sent a pull request to the first one. But they never responded. If you'd like I could integrate all the changes and post a single repository. I just need to know what to add. A pull request is the easiest way. But I can merge from your repos as well if you post them here.

https://github.com/travistabbal/Subsonic-Android


Thanks ttabbal. Could you please summarize what your changes add/change?

Thanks,
Osho
oshogg
 
Posts: 33
Joined: Thu Nov 12, 2009 3:43 pm

Re: Subsonic For ICS Android 4.0

Postby ttabbal » Thu May 24, 2012 2:53 pm

oshogg wrote:
ttabbal wrote:I agree that one CodeBase is good. I sent a pull request to the first one. But they never responded. If you'd like I could integrate all the changes and post a single repository. I just need to know what to add. A pull request is the easiest way. But I can merge from your repos as well if you post them here.

https://github.com/travistabbal/Subsonic-Android


Thanks ttabbal. Could you please summarize what your changes add/change?

Thanks,
Osho



Mostly the fixes for BT on ICS. I recently added the buffering config options from archival. I don't think I've pushed that to github yet though. I was testing it. I'll probably pull the rest of his changes over and update github so that there can be a single source. If sindre or whoever is maintaining the "official" repo wants to use it as a source later, that would be great. If nothing else, keeping things together will help everyone here testing builds.

Here's a build with the latest, it was faster than I expected to merge it. All of Archival's changes and mine. For a full changelog, look at the commit history on the github I posted earlier. It's been updated as well. If anyone else has changes they want me to pull in, please let me know via github pull request or here on the thread. I'll try to keep it updated as a merged source for any tested changes as well as post a build here so people can help test. Please provide feedback here so that everyone can try to fix bugs as they come up if you are testing. If we get more than a few people submitting changes, I'll figure out how to add people to that repo so they can push directly so everyone isn't waiting on me.

For other devs, if you use a git repo, your name stays attached to the commits when I merge them. That way credit/blame can be provided properly. :D
ttabbal
 
Posts: 33
Joined: Thu May 27, 2010 8:57 pm

Re: Subsonic For ICS Android 4.0

Postby archrival » Thu May 24, 2012 6:26 pm

ttabbal wrote:
oshogg wrote:
ttabbal wrote:I agree that one CodeBase is good. I sent a pull request to the first one. But they never responded. If you'd like I could integrate all the changes and post a single repository. I just need to know what to add. A pull request is the easiest way. But I can merge from your repos as well if you post them here.

https://github.com/travistabbal/Subsonic-Android


Thanks ttabbal. Could you please summarize what your changes add/change?

Thanks,
Osho



Mostly the fixes for BT on ICS. I recently added the buffering config options from archival. I don't think I've pushed that to github yet though. I was testing it. I'll probably pull the rest of his changes over and update github so that there can be a single source. If sindre or whoever is maintaining the "official" repo wants to use it as a source later, that would be great. If nothing else, keeping things together will help everyone here testing builds.

Here's a build with the latest, it was faster than I expected to merge it. All of Archival's changes and mine. For a full changelog, look at the commit history on the github I posted earlier. It's been updated as well. If anyone else has changes they want me to pull in, please let me know via github pull request or here on the thread. I'll try to keep it updated as a merged source for any tested changes as well as post a build here so people can help test. Please provide feedback here so that everyone can try to fix bugs as they come up if you are testing. If we get more than a few people submitting changes, I'll figure out how to add people to that repo so they can push directly so everyone isn't waiting on me.

For other devs, if you use a git repo, your name stays attached to the commits when I merge them. That way credit/blame can be provided properly. :D


Awesome, thanks for doing this.

There may be a few outstanding issues on ICS devices without a hardware menu button. There is another location that openOptionsMenu() is used (current playlist), it would need to be modified to allow that context menu to open. Android is moving away from Menu buttons and if you have the target SDK version to 11 or greater the openOptionsMenu() method no longer works. To get the context menus to work you need to enable the title bar (I don't think we want to do this). I made some changes to allow the app to work slightly differently on pre 3.x devices, most of which will not be Tablets and probably have a Menu button. I assume if you are 3.x or higher that you don't have a Menu button.

I'm also not sure I like the Help button on all tabs, it probably makes sense to have it on the main tab only. It isn't yet context aware so you get the same help regardless of the tab you are on and it just wastes space. In reality we could probably remove the Settings button on the other tabs as well, but I believe people would be more inclined to click Settings on other tabs.
archrival
 
Posts: 173
Joined: Wed May 26, 2010 6:02 am

PreviousNext

Return to General

Who is online

Users browsing this forum: No registered users and 11 guests