archrival wrote:Awesome, thanks for doing this.
There may be a few outstanding issues on ICS devices without a hardware menu button. There is another location that openOptionsMenu() is used (current playlist), it would need to be modified to allow that context menu to open. Android is moving away from Menu buttons and if you have the target SDK version to 11 or greater the openOptionsMenu() method no longer works. To get the context menus to work you need to enable the title bar (I don't think we want to do this). I made some changes to allow the app to work slightly differently on pre 3.x devices, most of which will not be Tablets and probably have a Menu button. I assume if you are 3.x or higher that you don't have a Menu button.
I'm also not sure I like the Help button on all tabs, it probably makes sense to have it on the main tab only. It isn't yet context aware so you get the same help regardless of the tab you are on and it just wastes space. In reality we could probably remove the Settings button on the other tabs as well, but I believe people would be more inclined to click Settings on other tabs.
I hope it helps. Your ideas sound good to me. I'm on a Galaxy Nexus 4.0.4, so I can help test menu button changes and maybe do some more coding. I get limited time for real dev stuff these days, but git merges and compiling is pretty fast.