[Bug] Error saving cover image if path contains ampersand

[mgrant]

Some of the folders in my music collection contain an ampersand. Subsonic throws an exception when attempting to save cover images into such folders.


[6/8/09 1:59:12 AM GMT] INFO AmazonSearchService Found 1 cover image(s) at Amazon.com in 552 ms.
[6/8/09 1:59:21 AM GMT] WARN CoverArtService Failed to save cover art for /music/You, Me & Iowa/You, Me & Iowa

[mixmaster]

Hmmm, I cannot repro this. I was able to download & save cover art for "A Man & The Blues". But I'm on Windows, looks like you're using a *nix?
________

[jigsaw]

Did a quick test on my Linux, but it works fine for me. I tested with both a comma and an ampersand. Maybe you should check the logs and see if you have any more info in the error message? Say maybe a "Permission denied" error message or something..?

[mgrant]

Did a quick test on my Linux, but it works fine for me. I tested with both a comma and an ampersand. Maybe you should check the logs and see if you have any more info in the error message? Say maybe a "Permission denied" error message or something..?

Looks like the problem is when the filesystem contains an HTML escaped ampersand (i.e. &)

So, in my example the actual path is:

/music/You\,\ Me\ \&amp\;\ Iowa/You\,\ Me\ \&amp\;\ Iowa

When displayed in the browser (or in the log) it automatically converts the "&" to just "&".

Apparently that's where subsonic chokes. Instead of trying to save the album art to:

/music/You\,\ Me\ \&amp\;\ Iowa/You\,\ Me\ \&amp\;\ Iowa

is tries to save it to:

/music/You\,\ Me\ \&\ Iowa/You\,\ Me\ \&\ Iowa

which, of course, doesn't exist.

[mgrant]

bump...

Any thoughts on if this is an actual bug? And if so when/if it will get fixed? Now that I understand why it's failing I've just been "fixing" the paths. It seems that the software I use to manage the folder structure builds the paths from the ID3 tags and some of the ID3 tags contain the offending HTML (mostly "&" instead of the simpler "&".

Thanks,

-mg

[sindre_mehus]

I've put it on my todo list, but can't promise when it will be fixed.

Thanks for reporting it